Align React RSC init floor with 19.2.6#1118
Merged
southpolesteve merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
Collaborator
Author
|
/bigbonk review please |
Contributor
There was a problem hiding this comment.
LGTM. Straightforward security-motivated version bump.
Checked:
- Catalog + peer deps —
pnpm-workspace.yamlcatalog,packages/vinext/package.jsonpeerDependencies, andtests/fixtures/static-export/package.jsonall consistently bumped to^19.2.6for react, react-dom, and react-server-dom-webpack. - Upgrade gate in
init.ts—getReactUpgradeDepsthreshold correctly moved frompatch < 5topatch < 6(line 177), so projects on 19.2.5 now get upgraded before RSDW is installed. Comments updated to match. cli.tscomment — Generalized from "react<19.2.5" to "older React versions", which is better since the exact floor will keep moving.- Test updates —
tests/init.test.tscorrectly uses19.2.5as the "below floor" version and19.2.6as the "new enough" version. The existing19.2.3and18.3.1tests still exercise the older-version paths. - Lockfile — Mechanical 19.2.5→19.2.6 substitution across all workspace importers and snapshot hashes. Spot-checked several entries; consistent throughout.
minimumReleaseAgeExclude— React packages are already excluded from the 1440-minute release age gate inpnpm-workspace.yaml, so the fresh 19.2.6 resolves without issues. Good.
No functional concerns. The GHSA-rv78-f8rc-xrxh advisory makes this a good candidate for a quick merge.
Contributor
|
Review posted. Approved PR #1118 -- the changes are clean and correct. All version references (catalog, peer deps, fixture package.json, upgrade gate threshold, tests) are consistently bumped from 19.2.5 to 19.2.6 to address GHSA-rv78-f8rc-xrxh. No issues found. |
cff3546 to
fd990d0
Compare
commit: |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react-server-dom-webpack@19.2.6Context
React published GHSA-rv78-f8rc-xrxh for
react-server-dom-*packages. The workspace catalog and lockfile already resolve to 19.2.6 on main; this PR keeps vinext's App Router init path aligned with that patched release.GHSA-rv78-f8rc-xrxh
Validation
./node_modules/.bin/vp test tests/init.test.ts./node_modules/.bin/vp check tests/init.test.tsgit diff --check origin/main...HEAD