Skip to content

Align React RSC init floor with 19.2.6#1118

Merged
southpolesteve merged 1 commit intomainfrom
codex/react-rsdw-19-2-6
May 6, 2026
Merged

Align React RSC init floor with 19.2.6#1118
southpolesteve merged 1 commit intomainfrom
codex/react-rsdw-19-2-6

Conversation

@southpolesteve
Copy link
Copy Markdown
Collaborator

@southpolesteve southpolesteve commented May 6, 2026

Summary

  • align the init/build React upgrade guard with react-server-dom-webpack@19.2.6
  • treat React 19.2.5 as below the App Router RSC floor so projects upgrade before installing RSDW
  • update init coverage for the new boundary

Context

React published GHSA-rv78-f8rc-xrxh for react-server-dom-* packages. The workspace catalog and lockfile already resolve to 19.2.6 on main; this PR keeps vinext's App Router init path aligned with that patched release.

GHSA-rv78-f8rc-xrxh

Validation

  • ./node_modules/.bin/vp test tests/init.test.ts
  • ./node_modules/.bin/vp check tests/init.test.ts
  • git diff --check origin/main...HEAD

@southpolesteve
Copy link
Copy Markdown
Collaborator Author

/bigbonk review please

Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Straightforward security-motivated version bump.

Checked:

  • Catalog + peer depspnpm-workspace.yaml catalog, packages/vinext/package.json peerDependencies, and tests/fixtures/static-export/package.json all consistently bumped to ^19.2.6 for react, react-dom, and react-server-dom-webpack.
  • Upgrade gate in init.tsgetReactUpgradeDeps threshold correctly moved from patch < 5 to patch < 6 (line 177), so projects on 19.2.5 now get upgraded before RSDW is installed. Comments updated to match.
  • cli.ts comment — Generalized from "react<19.2.5" to "older React versions", which is better since the exact floor will keep moving.
  • Test updatestests/init.test.ts correctly uses 19.2.5 as the "below floor" version and 19.2.6 as the "new enough" version. The existing 19.2.3 and 18.3.1 tests still exercise the older-version paths.
  • Lockfile — Mechanical 19.2.5→19.2.6 substitution across all workspace importers and snapshot hashes. Spot-checked several entries; consistent throughout.
  • minimumReleaseAgeExclude — React packages are already excluded from the 1440-minute release age gate in pnpm-workspace.yaml, so the fresh 19.2.6 resolves without issues. Good.

No functional concerns. The GHSA-rv78-f8rc-xrxh advisory makes this a good candidate for a quick merge.

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 6, 2026

Review posted. Approved PR #1118 -- the changes are clean and correct. All version references (catalog, peer deps, fixture package.json, upgrade gate threshold, tests) are consistently bumped from 19.2.5 to 19.2.6 to address GHSA-rv78-f8rc-xrxh. No issues found.

github run

@southpolesteve southpolesteve force-pushed the codex/react-rsdw-19-2-6 branch from cff3546 to fd990d0 Compare May 6, 2026 17:46
@southpolesteve southpolesteve changed the title Update React RSC packages to 19.2.6 Align React RSC init floor with 19.2.6 May 6, 2026
@southpolesteve southpolesteve marked this pull request as ready for review May 6, 2026 17:47
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 6, 2026

Open in StackBlitz

npm i https://pkg.pr.new/vinext@1118

commit: fd990d0

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original

@southpolesteve southpolesteve merged commit 37ea7a9 into main May 6, 2026
33 checks passed
@southpolesteve southpolesteve deleted the codex/react-rsdw-19-2-6 branch May 6, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant