fix: remove duplicate next-shims.d.ts from fixtures by Deepam02 · Pull Request #1170 · cloudflare/vinext

Deepam02 · 2026-05-11T17:38:46Z

three test fixtures had their own copy of next-shims.d.ts duplicating what already exists in the main package. Removed those and pointed each fixture's tsconfig at the single shared file instead.

Had to add a few missing declarations to the shared file first before removing the copies.

Signed-off-by: Deepam Goyal <deepam02goyal@gmail.com>

james-elicx · 2026-05-11T19:16:00Z

/bigbonk review

pkg-pr-new · 2026-05-11T19:16:50Z

Open in StackBlitz

npm i https://pkg.pr.new/vinext@1170

commit: f9df3b7

ask-bonk

Good cleanup — consolidating the duplicated .d.ts files is the right call. Two issues need fixing before merge.

CI is red

The Check job fails with 4 consistent-type-definitions lint errors. The newly added declarations use interface where this repo's lint config requires type. The fix is mechanical — see inline suggestions below.

Scope observation

The examples/ directory still has two stale next-shims.d.ts copies (realworld-api-rest, pages-router-cloudflare) that are also subsets of the shared file. Those are out of scope for this PR (fixtures ≠ examples), but worth noting for a follow-up.

ask-bonk · 2026-05-11T19:18:24Z

Review submitted. Here's a summary of the feedback:

Request changes on PR #1170 with two main points:

CI is failing — The Check job has 4 consistent-type-definitions lint errors. The newly added declarations in next-shims.d.ts use interface but the repo's lint config requires type. I left inline suggestions with the exact fixes for all 4 locations (lines 11, 16, 110, and 507).
Scope note — The examples/ directory still has two stale next-shims.d.ts copies (realworld-api-rest and pages-router-cloudflare) that are also subsets of the shared file. Noted as a follow-up opportunity, not a blocker for this PR.

github run

Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>

Deepam02 · 2026-05-11T19:32:20Z

@james-elicx Should I clean up the examples copies too or is that out of scope?

james-elicx · 2026-05-11T20:26:01Z

That would be great!

james-elicx · 2026-05-12T11:06:58Z

/bigbonk review

ask-bonk

Lint fixes look good — the type intersections from the first review are all addressed, and CI (vp check) passes clean. Tests all pass too (313 app-router, 204 pages-router, 916 shims+link).

One real bug to fix before merge, and a minor note.

Bug: `next/link` default export references undeclared value

The declare module "next/link" block defines LinkProps as a type but never declares Link as a value — then does export default Link referencing thin air. The deleted fixture copies all had const Link: ComponentType<LinkProps>; before the export. This is masked by skipLibCheck: true everywhere, but the declaration is incorrect — consumers get any for the default import.

Follow-up: examples cleanup

Per the thread with @james-elicx, the two stale copies in examples/ (realworld-api-rest, pages-router-cloudflare) should be cleaned up in this PR as well.

ask-bonk · 2026-05-12T11:10:56Z

+    onNavigate?: (event: { preventDefault(): void }) => void;
+    children?: ReactNode;
+  } & Omit<AnchorHTMLAttributes<HTMLAnchorElement>, "href">;
+  export default Link;


Bug: Link is referenced here but never declared as a value. The deleted fixture copies all had a const Link declaration. Without it, the default export resolves to any (hidden by skipLibCheck).

Suggested change

export default Link;

const Link: ComponentType<LinkProps>;

export default Link;

ask-bonk · 2026-05-12T11:11:03Z

Review submitted. Here's a summary:

One bug found, one follow-up noted.

Bug — next/link missing value declaration (next-shims.d.ts:121): The declare module "next/link" block does export default Link but never declares Link as a value. The deleted fixture copies all had const Link: ComponentType<LinkProps>; before the export. Without it, the default import resolves to any. This is masked by skipLibCheck: true but the declaration is incorrect. Left an inline suggestion with the fix.
Follow-up — examples cleanup: Per the existing thread, the two stale next-shims.d.ts copies in examples/realworld-api-rest and examples/pages-router-cloudflare should also be consolidated in this PR.

Everything else looks good — lint fixes from the first review are all addressed, vp check passes clean, and all tests pass (313 app-router, 204 pages-router, 916 shims+link).

github run

Apply the same consolidation from fixtures to examples/realworld-api-rest and examples/pages-router-cloudflare. Point their tsconfigs at the shared packages/vinext/src/shims/next-shims.d.ts instead of keeping local copies.

The deleted fixture copies all had `const Link: ComponentType<LinkProps>` before the default export. Without it the default import resolves to `any` (masked by skipLibCheck). Add the missing value declaration.

james-elicx · 2026-05-12T11:19:52Z

/bigbonk review

ask-bonk

All feedback from prior reviews has been addressed:

Lint fixes — All four consistent-type-definitions violations (interface → type intersection) are fixed. vp check passes.
next/link value declaration — const Link: ComponentType<LinkProps> is present before export default Link (line 121). Bug fixed.
Examples cleanup — Both examples/realworld-api-rest/next-shims.d.ts and examples/pages-router-cloudflare/next-shims.d.ts are removed; their tsconfigs point to the shared file.

Verified:

All 14 module declarations from the deleted fixtures/examples exist in the shared file (it's a superset).
All relative paths in tsconfig include arrays resolve correctly (../../../ for fixtures, ../../ for examples).
No stale next-shims.d.ts copies remain anywhere in the repo.
Check CI is green.

Clean consolidation — LGTM.

ask-bonk · 2026-05-12T11:22:08Z

Review submitted. Here's the summary:

Approved PR #1170. All feedback from the two prior review rounds has been addressed:

Lint fixes — All four consistent-type-definitions violations are fixed (interfaces converted to type intersections).
next/link bug — The missing const Link value declaration is now present before export default Link.
Examples cleanup — Both stale copies in examples/ are removed and their tsconfigs updated.

Verified that all 14 module declarations from deleted files exist in the shared file, all relative paths resolve correctly, and no stale copies remain anywhere in the repo. Check CI is green; remaining Vitest and E2E jobs are still pending.

github run

fix: remove duplicate next-shims.d.ts from fixtures

68b8fba

Signed-off-by: Deepam Goyal <deepam02goyal@gmail.com>

ask-bonk Bot requested changes May 11, 2026

View reviewed changes

Comment thread packages/vinext/src/shims/next-shims.d.ts Outdated

Comment thread packages/vinext/src/shims/next-shims.d.ts Outdated

Comment thread packages/vinext/src/shims/next-shims.d.ts Outdated

Comment thread packages/vinext/src/shims/next-shims.d.ts Outdated

fix: use type intersections

2c25110

Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>

ask-bonk Bot reviewed May 12, 2026

View reviewed changes

james-elicx added 2 commits May 12, 2026 12:18

fix: remove duplicate next-shims.d.ts from examples

1d17076

Apply the same consolidation from fixtures to examples/realworld-api-rest and examples/pages-router-cloudflare. Point their tsconfigs at the shared packages/vinext/src/shims/next-shims.d.ts instead of keeping local copies.

fix: declare Link value before default export in next/link shim

f9df3b7

The deleted fixture copies all had `const Link: ComponentType<LinkProps>` before the default export. Without it the default import resolves to `any` (masked by skipLibCheck). Add the missing value declaration.

ask-bonk Bot approved these changes May 12, 2026

View reviewed changes

james-elicx enabled auto-merge (squash) May 12, 2026 11:22

james-elicx merged commit 97f878a into cloudflare:main May 12, 2026
24 checks passed

	export default Link;
	const Link: ComponentType<LinkProps>;
	export default Link;

Conversation

Deepam02 commented May 11, 2026

Uh oh!

james-elicx commented May 11, 2026

Uh oh!

pkg-pr-new Bot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ask-bonk Bot left a comment

Choose a reason for hiding this comment

CI is red

Scope observation

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ask-bonk Bot commented May 11, 2026

Uh oh!

Deepam02 commented May 11, 2026

Uh oh!

james-elicx commented May 11, 2026

Uh oh!

james-elicx commented May 12, 2026

Uh oh!

ask-bonk Bot left a comment

Choose a reason for hiding this comment

Bug: next/link default export references undeclared value

Follow-up: examples cleanup

Uh oh!

ask-bonk Bot May 12, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot commented May 12, 2026

Uh oh!

james-elicx commented May 12, 2026

Uh oh!

ask-bonk Bot left a comment

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot commented May 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pkg-pr-new Bot commented May 11, 2026 •

edited

Loading

Bug: `next/link` default export references undeclared value