Skip to content

fix(tests): avoid Function constructor in codegen parity tests#154

Closed
NathanDrake2406 wants to merge 1 commit intocloudflare:mainfrom
NathanDrake2406:codex/fix-tests-no-implied-eval
Closed

fix(tests): avoid Function constructor in codegen parity tests#154
NathanDrake2406 wants to merge 1 commit intocloudflare:mainfrom
NathanDrake2406:codex/fix-tests-no-implied-eval

Conversation

@NathanDrake2406
Copy link
Copy Markdown
Contributor

Summary

  • replace new Function(...) usage in middleware codegen parity tests with runInNewContext from node:vm
  • preserve existing behavior assertions while removing no-implied-eval warnings

Verification

  • pnpm run lint
  • pnpm test tests/shims.test.ts

@NathanDrake2406
Copy link
Copy Markdown
Contributor Author

Closing per author request.

@NathanDrake2406 NathanDrake2406 deleted the codex/fix-tests-no-implied-eval branch February 27, 2026 08:12
southpolesteve added a commit that referenced this pull request Feb 27, 2026
Co-authored-by: ask-bonk[bot] <ask-bonk[bot]@users.noreply.github.com>
Co-authored-by: Steve Faulkner <sfaulkner@cloudflare.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant