Skip to content

chore: suppress no-implied-eval warnings in codegen tests#156

Merged
FredKSchott merged 1 commit intomainfrom
chore/fix-lint-no-implied-eval
Feb 27, 2026
Merged

chore: suppress no-implied-eval warnings in codegen tests#156
FredKSchott merged 1 commit intomainfrom
chore/fix-lint-no-implied-eval

Conversation

@FredKSchott
Copy link
Copy Markdown
Collaborator

@FredKSchott FredKSchott commented Feb 27, 2026

Summary

  • We merged some lint improvements in feat: type aware linting with tsgolint #38
  • but then, some outdated PRs got merged after, causing linting on main to break.
  • Adds eslint-disable-next-line no-implied-eval to 3 new Function() calls in tests/shims.test.ts

These tests intentionally use new Function() to evaluate generated
middleware codegen output. Add eslint-disable-next-line comments to
fix --deny-warnings CI failures.
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 27, 2026

Open in StackBlitz

npm i https://pkg.pr.new/vinext@156

commit: 05c8840

@FredKSchott
Copy link
Copy Markdown
Collaborator Author

self-approving, this just adds linter comments (no code changes) and fixes failing CI on main

@FredKSchott FredKSchott enabled auto-merge (squash) February 27, 2026 08:17
@github-actions
Copy link
Copy Markdown

Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original

@FredKSchott FredKSchott merged commit 7b050d2 into main Feb 27, 2026
23 checks passed
@FredKSchott FredKSchott deleted the chore/fix-lint-no-implied-eval branch February 27, 2026 08:18
southpolesteve pushed a commit that referenced this pull request Feb 27, 2026
Co-authored-by: ask-bonk[bot] <ask-bonk[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant