refactor(routing): extract shared compareRoutes comparator to utils

[james-elicx]

Summary

• Extracts the duplicated sort comparator into a new compareRoutes<T extends { pattern: string }>() function in routing/utils.ts, which already exports routePrecedence
• Replaces three identical inline comparators: scanPageRoutes and scanApiRoutes in pages-router.ts, and appRouter in app-router.ts
• No behaviour change — only deduplication

Testing

pnpm test tests/routing.test.ts tests/route-sorting.test.ts — 75 tests pass.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/vinext@322

commit: 6eefb7b

[james-elicx]

/bigbonk review

[github-actions]

Example	Preview	Production	Original
app-router-cloudflare	preview	production
pages-router-cloudflare	preview	production
app-router-playground	preview	production	original
realworld-api-rest	preview	production
nextra-docs-template	preview	production
benchmarks	preview	production
hackernews	preview	production	original

[ask-bonk]

Good — routePrecedence is only referenced in its own definition, its use inside compareRoutes, and a comment in an E2E test. No remaining direct imports from the routers.

---

This is a clean, straightforward deduplication. Here's the review:

LGTM. The change is correct and well-scoped.

What was done:

• Three identical inline comparators (a, b) => { const diff = routePrecedence(a.pattern) - routePrecedence(b.pattern); return diff !== 0 ? diff : a.pattern.localeCompare(b.pattern); } extracted into a single compareRoutes function in routing/utils.ts
• The generic constraint <T extends { pattern: string }> is the right choice — it works with both AppRoute and Route (and any future route type) without coupling utils.ts to those interfaces
• The routePrecedence import in app-router.ts and pages-router.ts is correctly replaced with compareRoutes
• routePrecedence remains exported for direct use (e.g., the E2E test references it in a comment, and it's useful as a standalone scoring function)

No behavioral change, no edge cases to worry about. The 75 passing tests confirm it.

github run