fix: propagate page generateMetadata errors to error boundary#374
Merged
james-elicx merged 1 commit intoj-branch-11from Mar 9, 2026
Merged
fix: propagate page generateMetadata errors to error boundary#374james-elicx merged 1 commit intoj-branch-11from
james-elicx merged 1 commit intoj-branch-11from
Conversation
When parallelising metadata resolution, layout errors should be swallowed (.catch(() => null)) but page-level generateMetadata() errors must propagate so the caller can route them to the nearest error.tsx or global-error.tsx boundary. Fixes the regression introduced by the parallelisation PR where a throwing generateMetadata() on the page module was silently swallowed instead of triggering the error boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generateMetadata()errors are still swallowed (.catch(() => null)) — a layout failing shouldn't crash the pagegenerateMetadata()errors now propagate out ofbuildPageElement()so the caller routes them to the nearesterror.tsxorglobal-error.tsxboundaryRoot Cause
The parallelisation PR applied
.catch(() => null)to all modules including the page module. This silently swallowed errors thrown bypage.generateMetadata(), preventing the error boundary from being triggered.Fix
Separate layout modules from the page module when resolving metadata/viewport in
buildPageElement():.catch(() => null)— failures are non-fatal.catch()— errors propagate to the caller, which routes toerror.tsx/global-error.tsxTest
The previously failing test now passes: