fix: eliminate react-dom/server.edge dual-import Rollup warning in SSR entry

[nianyi778]

Problem

The generated SSR entry module (generateSsrEntry()) imports react-dom/server.edge in two ways:

1. Static (top-level): import { renderToReadableStream } from "react-dom/server.edge"
2. Dynamic (inside handleSsr): const { renderToStaticMarkup } = await import("react-dom/server.edge")

Rollup detects this mixed static+dynamic import pattern and emits a warning on every production build:

"react-dom/server.edge" is dynamically imported by "..." but is also statically imported by "...",
dynamic import will not move module into a separate chunk.

This is cosmetic (the build succeeds), but it's noisy — especially for projects that suppress it via onwarn workarounds in their vite.config.ts.

Fix

Add renderToStaticMarkup to the existing static import at the top of the generated SSR entry, and remove the redundant dynamic import(). The module was already loaded — the dynamic import added no lazy-loading benefit since handleSsr() runs unconditionally during SSR and renderToReadableStream from the same module is always available.

-import { renderToReadableStream } from "react-dom/server.edge";
+import { renderToReadableStream, renderToStaticMarkup } from "react-dom/server.edge";

-    const { renderToStaticMarkup } = await import("react-dom/server.edge");
+    // NOTE: renderToStaticMarkup is imported statically at the top to avoid
+    // Rollup warnings about react-dom/server.edge being both statically and
+    // dynamically imported in the same module.

Verification

Tested with a vinext App Router project (Cloudflare Workers):

• Before: Rollup emits the dual-import warning on every vinext build
• After: Warning is eliminated, build output is clean
• tsc compiles without errors

[southpolesteve]

/bigbonk review

[ask-bonk]

Clean, correct fix. The SSR entry was already statically importing renderToReadableStream from react-dom/server.edge, so adding renderToStaticMarkup to the same import and dropping the redundant dynamic import() is the right call. The dynamic import provided no lazy-loading benefit since the module was already eagerly loaded.

Verified:

• No other dynamic imports of react-dom/server.edge remain in the file
• No other server files (prod-server.ts, worker-entry.ts) use renderToStaticMarkup, so there's no parity concern
• The remaining await import("react") on line 2257 is fine — react has no static import in the SSR entry, so it won't trigger the same Rollup warning

One minor nit below, but not blocking.

[ask-bonk]

Review submitted. Here's a summary:

Approved — This is a clean, correct fix. The change hoists renderToStaticMarkup into the existing static import from react-dom/server.edge and removes the redundant dynamic import(), eliminating the Rollup dual-import warning with no behavioral change.

Key verification points:

• No remaining dynamic imports of react-dom/server.edge in the file
• No parity concerns — renderToStaticMarkup is only used in the SSR entry generated by app-dev-server.ts, not in prod-server.ts or worker-entry.ts
• The remaining await import("react") at line 2257 doesn't trigger the same warning since react has no static import in the SSR entry

Left one optional nit suggesting the 3-line explanatory comment could be trimmed to a single line.

github run

[FredKSchott]

LGTM! Thanks @nianyi778

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/vinext@41

commit: 5dd31ff