refactor: make ExecutionContext ALS the single source of truth

[james-elicx]

Summary

• Remove `ctx` as an explicit parameter from internal functions (`triggerBackgroundRegeneration`, generated `_handleRequest`) so all downstream code consistently retrieves the Workers `ExecutionContext` via `getRequestExecutionContext()` from the ALS
• Remove duplicate `ExecutionContext` interface definitions in `isr-cache.ts` and `kv-cache-handler.ts`; use the canonical `ExecutionContextLike` from `shims/request-context.ts`
• Update `isr-cache.test.ts` to supply `ctx` via `runWithExecutionContext()` (ALS) instead of as a direct argument
• Update `entry-templates.test.ts` snapshots

Files changed

File	Change
`server/isr-cache.ts`	Drop `ctx?` param from `triggerBackgroundRegeneration()`; remove duplicate interface
`entries/app-rsc-entry.ts`	Drop `ctx` 4th param from generated `_handleRequest`; replace `ctx.waitUntil()` with `_getRequestExecutionContext()?.waitUntil()`
`cloudflare/kv-cache-handler.ts`	Remove duplicate `ExecutionContext` interface; use `ExecutionContextLike`
`tests/isr-cache.test.ts`	Update `ctx.waitUntil` test to use ALS
`tests/snapshots/entry-templates.test.ts.snap`	Regenerated (6 snapshots updated)

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/vinext@431

commit: f101ed0

[github-actions]

Example	Preview	Production	Original
app-router-cloudflare	preview	production
pages-router-cloudflare	preview	production
app-router-playground	preview	production	original
realworld-api-rest	preview	production
nextra-docs-template	preview	production
benchmarks	preview	production
hackernews	preview	production	original

[james-elicx]

/bigbonk review

[ask-bonk]

Clean refactoring. The change is straightforward and correct — all ctx parameter threading was already redundant since runWithExecutionContext(ctx, _run) wraps the entire request at the top of handler() (line 1440 in app-rsc-entry.ts), so getRequestExecutionContext() is always populated by the time any waitUntil call runs.

Verified:

1. ALS is always populated when needed. The outer handler(request, ctx) calls _runWithExecutionContext(ctx, _run) before any code path that reaches _getRequestExecutionContext()?.waitUntil(...). The ?. optional chaining correctly handles Node.js dev where ctx is undefined.

2. Dev/prod parity is fine. Checked pages-server-entry.ts and dev-server.ts — both already use the ALS pattern (_getRequestExecutionContext() in the inlined triggerBackgroundRegeneration). The dev-server.ts imports triggerBackgroundRegeneration from isr-cache.ts, so it picks up this change automatically. prod-server.ts doesn't use waitUntil directly.

3. KVCacheHandler retains the constructor fallback. The this.ctx field still exists as a fallback in _deleteInBackground and _put (getRequestExecutionContext() ?? this.ctx), which is the right call — it preserves backward compatibility for anyone constructing KVCacheHandler with an explicit ctx option outside the ALS scope.

4. Test coverage is adequate. The ALS test wraps triggerBackgroundRegeneration in runWithExecutionContext and asserts waitUntil is called. The "no ctx" test verifies the graceful no-op path.

5. Snapshot changes are mechanical — just the parameter removal and waitUntil pattern change, repeated across 6 test fixture snapshots. Verified they match the source template changes.

[ask-bonk]

Review submitted. I approved PR #431 with a detailed review covering:

• Correctness: The ALS is always populated before any waitUntil call because _runWithExecutionContext(ctx, _run) wraps the entire request at the handler entry point. Optional chaining (?.) correctly handles Node.js dev where no execution context exists.
• Dev/prod parity: pages-server-entry.ts and dev-server.ts already use the ALS pattern. dev-server.ts imports from isr-cache.ts so it picks up the change automatically.
• Backward compatibility: KVCacheHandler retains the constructor ctx fallback (getRequestExecutionContext() ?? this.ctx).
• Test coverage: Both the ALS path and the no-context graceful path are tested.
• Snapshots: Mechanical changes matching the source template updates.

All 25 CI checks pass.

github run