fix: add assets.directory to generated wrangler.jsonc#569
Conversation
commit: |
|
|
/bigbonk review |
There was a problem hiding this comment.
Clean, minimal fix. The directory: "dist/client" value is correct — @cloudflare/vite-plugin unconditionally writes static assets there, and wrangler 4.69+ requires the field when assets is an object.
Tests look good: the existing assertion was updated to include the new field, and the dedicated test for assets.directory provides clear documentation of the requirement and why the value is correct.
No concerns.
|
Approved PR #569. The change is straightforward and correct:
The value |
Summary
assetsobject that lacks adirectoryfield, causingvinext deployto fail with:The 'assets' property in your configuration is missing the required 'directory' propertydirectory: "dist/client"to the generatedassetsblock ingenerateWranglerConfig()— this is always the correct value since@cloudflare/vite-pluginunconditionally writes static assets todist/client/assetsobject shape, and added a dedicated test for thedirectoryfieldNotes
not_found_handling: "none"is intentional and unchanged — it ensures unmatched requests fall through to the user Worker (enabling SSR) rather than being handled by the asset worker directlyFixes #219