docs: update Vite 8 guidance#596
Conversation
commit: |
|
|
/bigbonk review please |
There was a problem hiding this comment.
Clean, well-structured docs PR. The Vite 8 guidance is accurate and consistent across all four documentation surfaces.
Verified against the Vite 8 migration guide:
oxcoveresbuild— correct, Vite 8 uses Oxc for JS transforms and esbuild config is deprecatedoptimizeDeps.rolldownOptionsoveroptimizeDeps.esbuildOptions— correct, Rolldown replaces esbuild for dep optimizationbuild.rolldownOptions/worker.rolldownOptionsoverbuild.rollupOptions/worker.rollupOptions— correct, these are the renamed optionslegacy.inconsistentCjsInterop: trueas a temporary escape hatch — correct, this is the documented opt-out for the stricter CJS default import behavior- Raised
build.targetbaseline — correct, Chrome 107→111, Firefox 104→114, Safari 16.0→16.4 - Lightning CSS for CSS minification — mentioned in the README paragraph, correct
Consistency check: The same four config keys (oxc, optimizeDeps.rolldownOptions, build.rolldownOptions, worker.rolldownOptions) are referenced identically in AGENTS.md, SKILL.md, config-examples.md, and troubleshooting.md. The README adds Lightning CSS to the list which makes sense for the user-facing context.
Test change: Bumping 8.0.0-beta.18 → 8.0.0 in tsconfig-paths-vite8.test.ts is the right call now that Vite 8 has a stable release. The test logic is unchanged.
Peer dep update: README now says vite ^7.0.0 || ^8.0.0 which matches the actual peerDependencies in packages/vinext/package.json.
One minor nit (non-blocking): the README paragraph at line 102 is dense — it packs migration guide, config recommendations, CJS interop workaround, and a link into a single paragraph. Consider splitting it into a short intro sentence + bullet list in a follow-up, similar to how AGENTS.md structures the same information.
All CI checks pass. LGTM.
|
Review posted and PR approved. Here's a summary of the review: PR #596 — docs: update Vite 8 guidance — Approved The PR adds Vite 8 guidance across 4 documentation surfaces (AGENTS.md, SKILL.md, config-examples.md, troubleshooting.md), updates the README with user-facing migration notes, and bumps the test version from I verified all the technical claims against the official Vite 8 migration guide:
One non-blocking suggestion: the dense README paragraph could be split into bullets in a follow-up for readability. All CI checks pass. |
Summary
Testing