Skip to content

docs: update Vite 8 guidance#596

Merged
southpolesteve merged 1 commit intomainfrom
codex/vite8-docs
Mar 20, 2026
Merged

docs: update Vite 8 guidance#596
southpolesteve merged 1 commit intomainfrom
codex/vite8-docs

Conversation

@southpolesteve
Copy link
Copy Markdown
Collaborator

Summary

  • add Vite 8 guidance to the README, agent instructions, and migration skill docs
  • call out Rolldown/Oxc-era config recommendations and common migration gotchas
  • update the Vite 8 tsconfig-paths test to use the stable release version

Testing

  • pnpm test tests/tsconfig-paths-vite8.test.ts

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 19, 2026

Open in StackBlitz

npm i https://pkg.pr.new/vinext@596

commit: 0922726

@github-actions
Copy link
Copy Markdown

Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original

@southpolesteve
Copy link
Copy Markdown
Collaborator Author

/bigbonk review please

Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, well-structured docs PR. The Vite 8 guidance is accurate and consistent across all four documentation surfaces.

Verified against the Vite 8 migration guide:

  • oxc over esbuild — correct, Vite 8 uses Oxc for JS transforms and esbuild config is deprecated
  • optimizeDeps.rolldownOptions over optimizeDeps.esbuildOptions — correct, Rolldown replaces esbuild for dep optimization
  • build.rolldownOptions / worker.rolldownOptions over build.rollupOptions / worker.rollupOptions — correct, these are the renamed options
  • legacy.inconsistentCjsInterop: true as a temporary escape hatch — correct, this is the documented opt-out for the stricter CJS default import behavior
  • Raised build.target baseline — correct, Chrome 107→111, Firefox 104→114, Safari 16.0→16.4
  • Lightning CSS for CSS minification — mentioned in the README paragraph, correct

Consistency check: The same four config keys (oxc, optimizeDeps.rolldownOptions, build.rolldownOptions, worker.rolldownOptions) are referenced identically in AGENTS.md, SKILL.md, config-examples.md, and troubleshooting.md. The README adds Lightning CSS to the list which makes sense for the user-facing context.

Test change: Bumping 8.0.0-beta.188.0.0 in tsconfig-paths-vite8.test.ts is the right call now that Vite 8 has a stable release. The test logic is unchanged.

Peer dep update: README now says vite ^7.0.0 || ^8.0.0 which matches the actual peerDependencies in packages/vinext/package.json.

One minor nit (non-blocking): the README paragraph at line 102 is dense — it packs migration guide, config recommendations, CJS interop workaround, and a link into a single paragraph. Consider splitting it into a short intro sentence + bullet list in a follow-up, similar to how AGENTS.md structures the same information.

All CI checks pass. LGTM.

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Mar 20, 2026

Review posted and PR approved. Here's a summary of the review:

PR #596 — docs: update Vite 8 guidance — Approved

The PR adds Vite 8 guidance across 4 documentation surfaces (AGENTS.md, SKILL.md, config-examples.md, troubleshooting.md), updates the README with user-facing migration notes, and bumps the test version from 8.0.0-beta.18 to 8.0.0.

I verified all the technical claims against the official Vite 8 migration guide:

  • Config key recommendations (oxc, optimizeDeps.rolldownOptions, build.rolldownOptions) are accurate
  • legacy.inconsistentCjsInterop: true is the correct escape hatch for CJS interop changes
  • The build.target baseline change and Lightning CSS mentions are correct
  • The peer dependency update in the README matches the actual package.json
  • The guidance is consistent across all docs files

One non-blocking suggestion: the dense README paragraph could be split into bullets in a follow-up for readability. All CI checks pass.

github run

@southpolesteve southpolesteve merged commit 9c2fd26 into main Mar 20, 2026
25 checks passed
@southpolesteve southpolesteve deleted the codex/vite8-docs branch March 20, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant