fix: remove some of any type annotations in index.ts#63
Merged
FredKSchott merged 5 commits intocloudflare:mainfrom Feb 27, 2026
Merged
fix: remove some of any type annotations in index.ts#63FredKSchott merged 5 commits intocloudflare:mainfrom
FredKSchott merged 5 commits intocloudflare:mainfrom
Conversation
situ2001
changed the title
Collaborator
|
/bigbonk review |
Contributor
|
@southpolesteve Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
Collaborator
|
Thanks @situ2001! using defineConfig like this in a framework is pretty unconventional, risk that features intended for end-user sneak into the implementation of defineConfig one day. Better to construct the object ourselves but type it correctly |
…nfig object defineConfig is an identity function meant for user-land vite.config files. Frameworks should use the UserConfig type annotation directly, which provides the same type inference without the semantic mismatch.
commit: |
southpolesteve
added a commit
that referenced
this pull request
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to add any type, since the types can be inferred from declaration of vite.