fix: encode non-ASCII route params in X-Vinext-Params header#678
Closed
seoJing wants to merge 1 commit intocloudflare:mainfrom
Closed
fix: encode non-ASCII route params in X-Vinext-Params header#678seoJing wants to merge 1 commit intocloudflare:mainfrom
seoJing wants to merge 1 commit intocloudflare:mainfrom
Conversation
Non-ASCII characters in dynamic route parameters (e.g., Korean slugs) cause a ByteString TypeError when set as HTTP header values during RSC streaming. Percent-encode the JSON before setting the header. Fixes cloudflare#83
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-ASCII characters in dynamic route parameters (e.g., Korean slugs) cause a ByteString TypeError when set as HTTP header values during RSC streaming. Percent-encode the JSON before setting the header.
Fixes #676