remove unused rsc-html-stream dep

[james-elicx]

No description provided.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/vinext@771

commit: 881db6e

[github-actions]

Example	Preview	Production	Original
app-router-cloudflare	preview	production
pages-router-cloudflare	preview	production
app-router-playground	preview	production	original
realworld-api-rest	preview	production
nextra-docs-template	preview	production
benchmarks	preview	production
hackernews	preview	production	original

[james-elicx]

/bigbonk review

[ask-bonk]

Removing the dependency itself looks correct — if nothing imports rsc-html-stream at runtime anymore, it shouldn't be in dependencies.

However, there are stale references to rsc-html-stream left in source code and tests that should be cleaned up in this PR:

Source comments:

• packages/vinext/src/build/standalone.ts:78 — comment mentions rsc-html-stream as an example of a package with subpath-only exports
• packages/vinext/src/build/standalone.ts:330 — comment says "The prod-server imports packages like rsc-html-stream at runtime"

Tests:

• tests/standalone-build.test.ts:359-398 — test "copies vinext runtime dependencies" uses rsc-html-stream as the fake runtime dep name
• tests/standalone-build.test.ts:401-447 — test "copies vinext runtime dependencies that only expose subpath exports" also uses rsc-html-stream

The tests aren't broken (they create fake packages with that name and don't actually install from npm), but it's misleading to use a package name that vinext no longer depends on. Consider renaming to a generic placeholder like some-runtime-dep or picking an actual current dependency (e.g., magic-string) for the examples and comments.

Not a blocker — the dependency removal itself is clean — but would be nice to sweep these while you're at it.

[ask-bonk]

Reviewed PR #771. The dependency removal from package.json, pnpm-lock.yaml, and pnpm-workspace.yaml is clean and correct. I left a comment noting that there are stale references to rsc-html-stream in comments in standalone.ts and as the fake package name in standalone-build.test.ts — not a blocker, but worth cleaning up while the name is being removed everywhere else.

github run