refactor: extract postcss plugin to own file#830
Merged
james-elicx merged 1 commit intomainfrom Apr 13, 2026
Merged
Conversation
Collaborator
Author
|
/bigbonk review |
commit: |
|
Contributor
There was a problem hiding this comment.
Clean extraction. Verified:
- The logic in
plugins/postcss.tsis identical to what was removed fromindex.ts(only naming changes:_postcssCache→postcssCache,_resolvePostcssStringPluginsUncached→resolvePostcssStringPluginsUncached, private function/const → named exports). index.tsimportsresolvePostcssStringPluginsfrom the new location and drops the re-exports (_resolvePostcssStringPlugins,_postcssCache).- Both test files now import directly from
plugins/postcss.jsusing the public export names instead of the underscore-prefixed re-exports. No remaining references to the old names in the codebase. - The new file has its own
node:path,node:fs,node:url, andnode:moduleimports — no missing dependencies. - Follows the existing
plugins/directory convention alongsidefonts.ts,og-assets.ts, etc.
No behavioral changes, no circular dependency risk.
Contributor
|
Reviewed and approved PR #830. The extraction is faithful — the PostCSS plugin resolution logic moved from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.