refactor: extract remaining internal exports#833
Merged
james-elicx merged 1 commit intomainfrom Apr 13, 2026
Merged
Conversation
Collaborator
Author
|
/bigbonk review |
commit: |
|
Contributor
There was a problem hiding this comment.
Clean extraction — the code is moved verbatim into well-scoped modules, imports are updated correctly, and no stale references remain.
Verified:
- Faithful extraction: all three functions (
stripServerExports,hasMdxFiles/mdxScanCache,scanPublicFileRoutes) are byte-for-byte identical to their former inline versions, with the expected import additions (parseAst/MagicString,fs/path). - No dangling references: no remaining
_hasMdxFiles,_mdxScanCache,_scanPublicFileRoutes, or_stripServerExportsanywhere in the codebase. - Cache isolation preserved:
mdxScanCacheis still module-level inutils/mdx-scan.ts, so the singleton behavior is maintained —index.tsand the tests import from the same module. - Public API unaffected: the removed re-exports were underscore-prefixed internal exports, not part of the
package.jsonexportsmap. No external consumers are broken. - Test imports correct: all three test files now import directly from the new module paths and use the non-prefixed names.
- File placement makes sense:
strip-server-exportsunderplugins/(it's a transform),mdx-scanandpublic-routesunderutils/.
No issues found.
Contributor
|
Reviewed and approved PR #833. The refactoring is a clean extraction of three internal utilities from the monolithic
The code is moved verbatim, all imports are updated correctly (both in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.