Don't fail-fast the LLVM build matrix#14
Merged
Conversation
When one platform's build fails the matrix currently cancels the other in-progress jobs, throwing away ~45 minutes of work on each. Set fail-fast: false so the remaining platforms continue to completion and upload their assets. Concretely this is needed because the windows-amd64 clang-tidy build currently fails: the windows-latest runner now ships MinGW GCC 15.2.0, whose libstdc++ no longer transitively pulls <cstdint> into <initializer_list>, and LLVM 18.1.8's SmallVector.h uses uint32_t/uint64_t without an explicit include. Upstream fixed this in later LLVM versions; our proper fix is to bump the LLVM pin. Until then, the linux and darwin platforms (the only ones any downstream consumes for clang-tidy) should not be blocked by the broken Windows build.
guybedford
force-pushed
the
gbedford/matrix-fail-fast-false
branch
from
846d85b to
903747d
Compare
guybedford
changed the title
danlapid
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When one platform's build in the LLVM build matrix fails the strategy currently cancels the other in-progress jobs, discarding the ~45 minutes of work each had done. Set
fail-fast: falseso the surviving platforms continue to completion and upload their assets.This came up because the
windows-amd64clang-tidy build currently fails onwindows-latest: the runner now ships MinGW GCC 15.2.0, whose libstdc++ no longer transitively pulls<cstdint>into<initializer_list>, and LLVM 18.1.8'sSmallVector.husesuint32_t/uint64_twithout an explicit include. That made the priorclang-tidy-18.1.8dispatch cancel the darwin and linux builds we actually wanted. With this change those three would have completed and uploaded their binaries +clang-tidy-devheader tarballs.The Windows failure is real and visible — the workflow run still shows red, the Windows job still shows red. The proper fix is bumping our LLVM pin (later versions already include the missing
#include <cstdint>upstream); this PR just stops the windows breakage from also taking down the healthy platforms.