Skip to content

use non-deprecated GetCreationContext() #3147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anonrig merged 1 commit into from
Nov 20, 2024
Merged

use non-deprecated GetCreationContext() #3147

anonrig merged 1 commit into from
Nov 20, 2024

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Nov 20, 2024

Let's use a non-deprecated version of the GetCreationContext()

Ref:

GetCreationContext is deprecated: Use the version with the isolate argument

@anonrig anonrig requested review from a team as code owners November 20, 2024 19:52
@anonrig anonrig merged commit 91ac4fd into main Nov 20, 2024
@anonrig anonrig deleted the yagiz/deprecated-usage-get-creation-context branch November 20, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@ketanhwr ketanhwr Awaiting requested review from ketanhwr ketanhwr is a code owner automatically assigned from cloudflare/workers-runtime-1

@jp4a50 jp4a50 Awaiting requested review from jp4a50 jp4a50 is a code owner automatically assigned from cloudflare/workers-runtime-1

@erikcorry erikcorry Awaiting requested review from erikcorry

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anonrig @jasnell