pass more websocket web-platform tests

[anonrig]

No description provided.

[ask-bonk]

I'm Bonk, and I've done a quick review of your PR.

This PR moves WebSocket close() code/reason validation before readyState checks and changes the error type from TypeError to InvalidAccessError, fixing spec compliance and enabling more WPT tests to pass.

Issues

1. [HIGH] Ungated behavioral change — error type and ordering. Two observable behaviors change here without a compat flag: (a) the exception type switches from TypeError to InvalidAccessError, and (b) validation now runs before readyState/state checks, meaning close(9999) on an already-closed socket will throw instead of silently returning. Both changes are spec-correct, but existing Workers that catch (e) { if (e instanceof TypeError) ... } or rely on the silent-return path will break. Per workerd's backward compat commitment, these should be gated behind a compatibility flag.

Note: these comments are generated by an AI assistant and may not be perfect. Please evaluate them critically.

[ask-bonk]

I'm Bonk, and I've done a quick review of your PR.

This PR moves WebSocket close() code/reason validation before readyState checks and changes the error type from TypeError to InvalidAccessError, fixing spec compliance and enabling more WPT tests to pass.

Issue found (HIGH severity): The PR makes two ungated observable behavioral changes: (1) the exception type switches from TypeError to InvalidAccessError, and (2) validation now runs before readyState/state checks, meaning invalid-code calls on already-closed sockets will throw instead of silently returning. Both are spec-correct, but per workerd's backward compat commitment, they should be gated behind a compatibility flag.

Review posted to the PR with an inline comment on the affected code.

github run

[dom96]

See comment, otherwise LGTM