Skip to content

Comments

Add a little more detail to actor sqlite commit tracing#6164

Merged
a-robinson merged 1 commit intomainfrom
arobinson/sqlite-commit-tracing
Feb 24, 2026
Merged

Add a little more detail to actor sqlite commit tracing#6164
a-robinson merged 1 commit intomainfrom
arobinson/sqlite-commit-tracing

Conversation

@a-robinson
Copy link
Member

To make it more obvious what's happening in traces when there's a delay between the actor_sqlite_commit span and the callback being called.

@a-robinson a-robinson requested a review from shrima-cf February 24, 2026 22:37
@a-robinson a-robinson requested review from a team as code owners February 24, 2026 22:37
@a-robinson a-robinson requested a review from justin-mp February 24, 2026 22:37
@ask-bonk
Copy link
Contributor

ask-bonk bot commented Feb 24, 2026

LGTM

github run

@a-robinson a-robinson force-pushed the arobinson/sqlite-commit-tracing branch from dcda63e to 39a8ed2 Compare February 24, 2026 22:39
To make it more obvious what's happening in traces when there's a delay
between the actor_sqlite_commit span and the callback being called.
@a-robinson a-robinson force-pushed the arobinson/sqlite-commit-tracing branch from 39a8ed2 to 1637075 Compare February 24, 2026 22:40
@a-robinson a-robinson removed the request for review from justin-mp February 24, 2026 22:40
@a-robinson a-robinson enabled auto-merge February 24, 2026 22:41
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 24, 2026

Merging this PR will improve performance by 19.34%

⚡ 1 improved benchmark
✅ 69 untouched benchmarks
⏩ 129 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
jsonResponse[Response] 47.7 µs 40 µs +19.34%

Comparing arobinson/sqlite-commit-tracing (1637075) with main (8583ec1)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@a-robinson a-robinson merged commit 523a84b into main Feb 24, 2026
24 of 25 checks passed
@a-robinson a-robinson deleted the arobinson/sqlite-commit-tracing branch February 24, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants