Skip to content

Restructure agent files for easier maintenance and cleaner org#6179

Merged
jasnell merged 1 commit intomainfrom
jasnell/agent-refinements-4
Feb 25, 2026
Merged

Restructure agent files for easier maintenance and cleaner org#6179
jasnell merged 1 commit intomainfrom
jasnell/agent-refinements-4

Conversation

@jasnell
Copy link
Collaborator

@jasnell jasnell commented Feb 25, 2026

Continued refinement of the agent instructions...

Moving the actual checklists out of .opencode and into docs makes it easier to reference from other agents (like claude code or windsurf)... also makes them easier to find for users who are looking for reference materials.

Restructure the checklists themselves to be more consistent, clearer, and actionable. Also reduce redundancy where possible.

Importantly, this starts to refine the initial AI-generated text into something more concise and correct. A few marginally odd details that the AI agent inserted are removed.

Moving the actual checklists out of .opencode and into
docs makes it easier to reference from other agents
(like claude code or windsurf)... also makes them easier
to find for users who are looking for reference materials.

Restructure the checklists themselves to be more consistent,
clearer, and actionable. Also reduce redundancy where possible.
@jasnell jasnell requested review from a team as code owners February 25, 2026 19:11
@ask-bonk
Copy link
Contributor

ask-bonk bot commented Feb 25, 2026

I'm Bonk, and I've done a quick review of your PR.

This PR adds new AI Gateway options (retries, event ID, request timeout) to the run() method along with extraHeaders support, and updates type definitions across all generated snapshots.

Two issues found and posted as review comments:

  1. [MED] extraHeaders silently dropped when no gateway options provided — In getHeadersFromOptions, the extraHeaders processing block is nested inside if (options) where options is the GatewayOptions parameter. If a caller passes run(data, { extraHeaders: {...} }) without gateway, the extra headers are silently ignored. Posted a suggestion to move the extraHeaders block outside the if (options) guard.

  2. [LOW] Type mismatch between implementation and .d.ts — The implementation now uses UniversalGatewayOptions (omitting id) for the gateway option in run(), but types/defines/aig.d.ts and all generated snapshots still use GatewayOptions (where id: string is required). Since run() already knows its gateway ID from the constructor, the types should match the implementation.

github run

@jasnell
Copy link
Collaborator Author

jasnell commented Feb 25, 2026

@elithrar ... more Bonk shenanigans... posting reviews on the wrong PRs

@jasnell jasnell merged commit 1a28cb8 into main Feb 25, 2026
23 checks passed
@jasnell jasnell deleted the jasnell/agent-refinements-4 branch February 25, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants