Skip to content

containers: Make sure req.url in the worker has format 'http://...' and egress listener should be backed by an atomic boolean to not start it twice#6194

Merged
gabivlj merged 1 commit intomainfrom
gv/more-fixes-egress
Feb 26, 2026
Merged

containers: Make sure req.url in the worker has format 'http://...' and egress listener should be backed by an atomic boolean to not start it twice#6194
gabivlj merged 1 commit intomainfrom
gv/more-fixes-egress

Conversation

@gabivlj
Copy link
Contributor

@gabivlj gabivlj commented Feb 26, 2026

Should make it less flakey

@gabivlj gabivlj requested review from a team as code owners February 26, 2026 20:50
@ask-bonk
Copy link
Contributor

ask-bonk bot commented Feb 26, 2026

UnknownError: "Overloaded"

github run

@ask-bonk
Copy link
Contributor

ask-bonk bot commented Feb 26, 2026

@gabivlj Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 26, 2026

Merging this PR will degrade performance by 16.26%

❌ 1 regressed benchmark
✅ 69 untouched benchmarks
⏩ 129 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
jsonResponse[Response] 39.9 µs 47.6 µs -16.26%

Comparing gv/more-fixes-egress (709c7c2) with main (093c149)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

…nd egress listener should be backed by an atomic boolean to not start it twice
@gabivlj gabivlj force-pushed the gv/more-fixes-egress branch from 2009d91 to 709c7c2 Compare February 26, 2026 21:24
@gabivlj
Copy link
Contributor Author

gabivlj commented Feb 26, 2026

using jsg.Url as suggested async

@gabivlj gabivlj merged commit 6644a67 into main Feb 26, 2026
22 checks passed
@gabivlj gabivlj deleted the gv/more-fixes-egress branch February 26, 2026 21:56
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.63%. Comparing base (093c149) to head (709c7c2).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/workerd/server/container-client.c++ 0.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6194      +/-   ##
==========================================
- Coverage   70.64%   70.63%   -0.02%     
==========================================
  Files         413      413              
  Lines      109876   109895      +19     
  Branches    18104    18107       +3     
==========================================
- Hits        77626    77625       -1     
- Misses      21443    21463      +20     
  Partials    10807    10807              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants