Skip to content

Add MySQL port to Hyperdrive binding#6195

Merged
danlapid merged 1 commit intocloudflare:mainfrom
prydt:prydt/hyperdrive-add-mysql-port
Mar 4, 2026
Merged

Add MySQL port to Hyperdrive binding#6195
danlapid merged 1 commit intocloudflare:mainfrom
prydt:prydt/hyperdrive-add-mysql-port

Conversation

@prydt
Copy link
Contributor

@prydt prydt commented Feb 26, 2026

This change makes Hyperdrive's magic connection string port match the database the user is using. This does not and should not change functionality, it just changes the user visible port to avoid confusion.

@prydt prydt requested review from a team as code owners February 26, 2026 21:33
@prydt prydt force-pushed the prydt/hyperdrive-add-mysql-port branch from 3577ea4 to b1b459d Compare February 26, 2026 22:11
@prydt prydt force-pushed the prydt/hyperdrive-add-mysql-port branch from b1b459d to 737099e Compare February 26, 2026 22:37
@prydt prydt force-pushed the prydt/hyperdrive-add-mysql-port branch from 737099e to a1ed9ab Compare February 26, 2026 22:45
@a-robinson a-robinson enabled auto-merge February 26, 2026 23:15
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.61%. Comparing base (0b27b08) to head (cd975ae).
⚠️ Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
src/workerd/api/hyperdrive.c++ 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6195      +/-   ##
==========================================
+ Coverage   70.59%   70.61%   +0.01%     
==========================================
  Files         413      413              
  Lines      109970   109998      +28     
  Branches    18121    18123       +2     
==========================================
+ Hits        77634    77673      +39     
+ Misses      21525    21518       -7     
+ Partials    10811    10807       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@a-robinson a-robinson force-pushed the prydt/hyperdrive-add-mysql-port branch from a1ed9ab to cd975ae Compare March 2, 2026 14:44
@a-robinson
Copy link
Member

Rebased in order to fix the internal build.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 2, 2026

Merging this PR will improve performance by 26.77%

⚡ 1 improved benchmark
✅ 69 untouched benchmarks
⏩ 129 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
bodyWithHeaders[Response] 38.2 µs 30.1 µs +26.77%

Comparing prydt:prydt/hyperdrive-add-mysql-port (cd975ae) with main (cce9f17)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@a-robinson
Copy link
Member

@jasnell @anonrig I'm sorry but I'm totally lost on how to get this internal-build target to pass for this PR given that @prydt isn't a member of our github org. Does either of you know what's needed?

I've created internal branches called both prydt/hyperdrive-add-mysql-port and workerd-robot/prydt/hyperdrive-add-mysql-port that have had their tests pass, but anytime I re-trigger the "internal-build" target here it just fails immediately with the following output:

Run echo "Fork detected. Checking if $AUTHOR is a Cloudflare org member..."
Fork detected. Checking if prydt is a Cloudflare org member...
✗ Not a Cloudflare org public member

This workflow only runs for forks from Cloudflare organization public members.
If you're an external contributor, please ask the auto-assigned reviewers
to run the internal build workflow on your behalf.

@jasnell
Copy link
Collaborator

jasnell commented Mar 2, 2026

heh, you know I have absolutely no idea. @npaun or @fhanau might know

@danlapid
Copy link
Collaborator

danlapid commented Mar 2, 2026

@jasnell feel free to use your judgement and just force merge if it doesn't seem to be likely to break the internal build, especially if an internal PR was created and passed.

@a-robinson
Copy link
Member

Is anyone able to force merge this? I'm still getting the same error message when trying to re-run the "internal-build" target, but I pinky swear this change doesn't break anything.

If not I can always copy @prydt 's change from his fork to the main repo and create a new PR, but it seems a little silly if there's a way to force the merge of this PR.

@danlapid danlapid disabled auto-merge March 4, 2026 18:42
@danlapid danlapid merged commit 764a346 into cloudflare:main Mar 4, 2026
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants