Add MySQL port to Hyperdrive binding#6195
Conversation
3577ea4 to
b1b459d
Compare
b1b459d to
737099e
Compare
737099e to
a1ed9ab
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6195 +/- ##
==========================================
+ Coverage 70.59% 70.61% +0.01%
==========================================
Files 413 413
Lines 109970 109998 +28
Branches 18121 18123 +2
==========================================
+ Hits 77634 77673 +39
+ Misses 21525 21518 -7
+ Partials 10811 10807 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a1ed9ab to
cd975ae
Compare
|
Rebased in order to fix the internal build. |
Merging this PR will improve performance by 26.77%
Performance Changes
Comparing Footnotes
|
|
@jasnell @anonrig I'm sorry but I'm totally lost on how to get this internal-build target to pass for this PR given that @prydt isn't a member of our github org. Does either of you know what's needed? I've created internal branches called both |
|
@jasnell feel free to use your judgement and just force merge if it doesn't seem to be likely to break the internal build, especially if an internal PR was created and passed. |
|
Is anyone able to force merge this? I'm still getting the same error message when trying to re-run the "internal-build" target, but I pinky swear this change doesn't break anything. If not I can always copy @prydt 's change from his fork to the main repo and create a new PR, but it seems a little silly if there's a way to force the merge of this PR. |
This change makes Hyperdrive's magic connection string port match the database the user is using. This does not and should not change functionality, it just changes the user visible port to avoid confusion.