Skip to content

Revert "Update standard.c++ pumpTo impl to use draining read"#6248

Merged
jasnell merged 1 commit intomainfrom
jasnell/revert-226e56f
Mar 5, 2026
Merged

Revert "Update standard.c++ pumpTo impl to use draining read"#6248
jasnell merged 1 commit intomainfrom
jasnell/revert-226e56f

Conversation

@jasnell
Copy link
Collaborator

@jasnell jasnell commented Mar 5, 2026

This reverts commit 226e56f.

Appears to be causing some issues. Still investigating

@jasnell jasnell requested review from danlapid and ketanhwr March 5, 2026 01:23
@jasnell jasnell requested review from a team as code owners March 5, 2026 01:23
@ask-bonk
Copy link
Contributor

ask-bonk bot commented Mar 5, 2026

ResolveMessage: Cannot find module '@opencode-ai/plugin' from '/home/runner/work/workerd/workerd/.opencode/tools/bazel-deps.ts'

github run

@ask-bonk
Copy link
Contributor

ask-bonk bot commented Mar 5, 2026

@jasnell Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@ask-bonk
Copy link
Contributor

ask-bonk bot commented Mar 5, 2026

ResolveMessage: Cannot find module '@opencode-ai/plugin' from '/home/runner/work/workerd/workerd/.opencode/tools/bazel-deps.ts'

github run

@jasnell jasnell requested a review from anonrig March 5, 2026 01:30
@codspeed-hq

This comment was marked as outdated.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 80.92105% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.67%. Comparing base (19e6211) to head (c9309c6).

Files with missing lines Patch % Lines
src/workerd/api/streams/standard.c++ 81.45% 12 Missing and 16 partials ⚠️
src/workerd/api/streams-test.c++ 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6248      +/-   ##
==========================================
- Coverage   70.71%   70.67%   -0.04%     
==========================================
  Files         417      417              
  Lines      111089   111090       +1     
  Branches    18340    18329      -11     
==========================================
- Hits        78558    78515      -43     
- Misses      21581    21631      +50     
+ Partials    10950    10944       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell jasnell merged commit f27a58c into main Mar 5, 2026
48 of 54 checks passed
@jasnell jasnell deleted the jasnell/revert-226e56f branch March 5, 2026 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants