Skip to content

Move the coverage-linux workflow to separate group#6249

Merged
jasnell merged 1 commit intomainfrom
jasnell/move-coverage-linux-to-separate-group
Mar 5, 2026
Merged

Move the coverage-linux workflow to separate group#6249
jasnell merged 1 commit intomainfrom
jasnell/move-coverage-linux-to-separate-group

Conversation

@jasnell
Copy link
Collaborator

@jasnell jasnell commented Mar 5, 2026

Moves it to a separate group to avoid it making the main test workflow take much longer to complete.

Moves it to a separate group to avoid it making the
main test workflow take much longer to complete.
@jasnell jasnell requested review from anonrig and fhanau March 5, 2026 01:49
@jasnell jasnell requested review from a team as code owners March 5, 2026 01:49
@ask-bonk
Copy link
Contributor

ask-bonk bot commented Mar 5, 2026

ResolveMessage: Cannot find module '@opencode-ai/plugin' from '/home/runner/work/workerd/workerd/.opencode/tools/bazel-deps.ts'

github run

@ask-bonk
Copy link
Contributor

ask-bonk bot commented Mar 5, 2026

@jasnell Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@fhanau
Copy link
Contributor

fhanau commented Mar 5, 2026

In terms of the motivation for this PR – the coverage job is not required to pass and no other jobs depend on it, so this wouldn't affect the time at which jobs finish or how long it takes for CI to pass. I guess one possible upside is that notifications about the test group failing will be delivered earlier?
Edit: As mentioned via chat, this would allow restarting the test group earlier. That makes sense, it would not be needed if running jobs can just be canceled when coverage is taking too long but IIRC that wasn't always possible.

@ask-bonk
Copy link
Contributor

ask-bonk bot commented Mar 5, 2026

ResolveMessage: Cannot find module '@opencode-ai/plugin' from '/home/runner/work/workerd/workerd/.opencode/tools/bazel-deps.ts'

github run

@jasnell
Copy link
Collaborator Author

jasnell commented Mar 5, 2026

the main motivation is not blocking the ability to restart the main set of tests

@jasnell jasnell merged commit efa616a into main Mar 5, 2026
24 of 26 checks passed
@jasnell jasnell deleted the jasnell/move-coverage-linux-to-separate-group branch March 5, 2026 04:40
@anonrig
Copy link
Member

anonrig commented Mar 5, 2026

fyi: the changes in coverage.yml resulted in more workflow runs to be executed and creating congestion... several runs are now queued

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants