Adds tail attributes from caller to tail workers#6254
Conversation
|
ResolveMessage: Cannot find module '@opencode-ai/plugin' from '/home/runner/work/workerd/workerd/.opencode/tools/bazel-deps.ts' |
|
@Caio-Nogueira Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
|
The generated output of |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6254 +/- ##
==========================================
- Coverage 70.80% 70.75% -0.06%
==========================================
Files 420 420
Lines 112299 112391 +92
Branches 18417 18443 +26
==========================================
+ Hits 79513 79520 +7
- Misses 21789 21871 +82
- Partials 10997 11000 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d8eda22 to
bb51205
Compare
e583699 to
ad49500
Compare
ad49500 to
9aca7be
Compare
9aca7be to
2425b02
Compare
petebacondarwin
left a comment
There was a problem hiding this comment.
The PR calls these "tail tags" but the code calls them "tail attributes". Is that just the PR being outdated or am I missing the connection?
Yeah, the PR description was outdated. We are using the term "tail attributes" for these tags now |
| for (const auto& value: tag.value) { | ||
| KJ_SWITCH_ONEOF(value) { | ||
| KJ_CASE_ONEOF(boolean, bool) { | ||
| tracker.trackFieldWithSize("tailAttributeValue", sizeof(boolean)); |
There was a problem hiding this comment.
This should not be needed – we don't do memory allocation for the given bool/double/integer types, and the type we have here (e.g. bool vs. double) doesn't matter since the size of tracing::Attribute is fixed.
Adds tail tags to the Trace object and mirror these tags with attributes on the OnSet event