Revert "Fix Python ASGI adaptor to handle streaming responses correctly"#6305
Merged
Revert "Fix Python ASGI adaptor to handle streaming responses correctly"#6305
Conversation
hoodmane
approved these changes
Mar 11, 2026
Contributor
|
The only differences are copyright headers added by another commit. This is a clean revert. My earlier analysis was wrong because I was comparing against the wrong base commit ( This is a clean revert of PR #6173. The code changes are straightforward — they restore the pre-#6173 ASGI adaptor logic and test structure. The revert is internally consistent and all the files match the pre-#6173 state (modulo copyright headers added by an unrelated commit). LGTM |
jasnell
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #6173
Until we can figure out the cause let's revert.