Skip logging script startup exceptions for dynamic workers

[ketanhwr]

No description provided.

[ask-bonk]

The change is clear and straightforward. Let me analyze it:

Before the change: KJ_LOG(ERROR, ...) was called unconditionally for both dynamic and non-dynamic workers, then the code branched on isDynamicWorker to either rethrow or KJ_FAIL_REQUIRE.

After the change: KJ_LOG(ERROR, ...) is only called in the else (non-dynamic worker) branch, right before KJ_FAIL_REQUIRE. Dynamic workers skip the KJ_LOG entirely and just rethrow.

This makes sense — for dynamic workers, the exception is rethrown to the caller as a JS Error, so the caller can handle it. Logging it as an ERROR in the server logs would be noisy for what is expected user-facing behavior. The span logging (span.addLog(...)) still happens for both paths, preserving observability through tracing.

This is a clean, minimal, correct change. No backward compatibility concerns (this is internal logging behavior, not user-facing API). No safety issues. The span-based tracing is still unconditional. The logic is sound.

LGTM

github run