Skip to content

Fixup regression in getBuiltinModule#6343

Merged
jasnell merged 2 commits intomainfrom
jasnell/fix-getbuiltinmodule-regression
Mar 17, 2026
Merged

Fixup regression in getBuiltinModule#6343
jasnell merged 2 commits intomainfrom
jasnell/fix-getbuiltinmodule-regression

Conversation

@jasnell
Copy link
Collaborator

@jasnell jasnell commented Mar 17, 2026

Following the node:process redirect change, the impl was not correctly filtering out node-internal:* and cloudflare-internal:* modules when using the original module registry, and the new module registry hadn't been updated to account for the new API.

@jasnell jasnell requested review from anonrig and guybedford March 17, 2026 14:57
@jasnell jasnell requested review from a team as code owners March 17, 2026 14:57
ask-bonk[bot]

This comment was marked as resolved.

@ask-bonk

This comment was marked as resolved.

Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
@codspeed-hq

This comment was marked as outdated.

@jasnell jasnell requested a review from anonrig March 17, 2026 17:33
@jasnell jasnell merged commit 99c199d into main Mar 17, 2026
35 of 37 checks passed
@jasnell jasnell deleted the jasnell/fix-getbuiltinmodule-regression branch March 17, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants