Merged
Conversation
anonrig
approved these changes
Mar 19, 2026
Contributor
|
UnknownError: "Overloaded" |
Contributor
|
@erikcorry Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
jasnell
approved these changes
Mar 19, 2026
erikcorry
force-pushed
the
erikcorry/fix-thread-safety
branch
from
1f46ce2 to
acd6899
Compare
Contributor
|
normally for something like this, i'd go with acquire/release semantics . i guess i don't know what workerd generally goes with for this type of thing, but explicit loads and stores make atomic semantics much more clear |
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since terminateExecution can be called from other threads this needs to be atomic