Skip to content

STREAM-6700: drop upload via File support#6367

Merged
danlapid merged 1 commit intocloudflare:mainfrom
natewong1313:nwong/STREAM-6700
Mar 19, 2026
Merged

STREAM-6700: drop upload via File support#6367
danlapid merged 1 commit intocloudflare:mainfrom
natewong1313:nwong/STREAM-6700

Conversation

@natewong1313
Copy link
Contributor

Removes uploading videos via File in favor of users uploading via link. We want users to upload files via ReadableStream instead but that will come in a later iteration

@natewong1313 natewong1313 requested a review from a team as a code owner March 19, 2026 20:42
@natewong1313 natewong1313 requested review from a team as code owners March 19, 2026 21:01
Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a breaking change to the binding—will this break customers in production?

@natewong1313
Copy link
Contributor Author

This seems like a breaking change to the binding—will this break customers in production?

Sorry should have mentioned in the description but we havent rolled the binding out to Customers yet

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@d05ea20). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6367   +/-   ##
=======================================
  Coverage        ?   70.53%           
=======================================
  Files           ?      420           
  Lines           ?   113996           
  Branches        ?    18788           
=======================================
  Hits            ?    80410           
  Misses          ?    22354           
  Partials        ?    11232           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 19, 2026

Merging this PR will improve performance by 26.15%

⚡ 1 improved benchmark
✅ 69 untouched benchmarks
⏩ 129 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
bodyWithHeaders[Response] 38.9 µs 30.9 µs +26.15%

Comparing natewong1313:nwong/STREAM-6700 (060bd90) with main (d05ea20)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@danlapid danlapid merged commit 4a59422 into cloudflare:main Mar 19, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants