Revert changes causing Windows release CI to fail

[fhanau]

After re-running numerous CI jobs, it appears that 1f638e0 was the last commit where clang did not crash when building server.c++ (or was not crashing consistently at least). The next change affecting server.c++ was in #6059, revert this to restore the build.
I'm also reverting a commit that attempted to fix the issue but failed to do so. Note that this is one of two commits in #6402, with the other commit I'm not sure, it may or may not have fixed the crash for container-client.c++ whereas the commit reverted here tries to solve a problem that doesn't exist; the goto that it complains about was around since before we've started experiencing these crashes.

Reproduction of error and how this fixes it – see #6416: In f500ffd, we see that compilation of server.c++ fails for a Windows build modified to resemble release settings. But in the follow-up commit 38ad8c2 which has the reverts applied, CI is expected to pass.

Still needs more work.

[ask-bonk]

LGTM

github run

[codecov-commenter]

Codecov Report

❌ Patch coverage is 70.76923% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.77%. Comparing base (47f5816) to head (c28f13d).

Files with missing lines	Patch %	Lines
src/workerd/server/server.c++	50.00%	12 Missing and 4 partials ⚠️
src/workerd/api/sockets.c++	81.81%	0 Missing and 2 partials ⚠️
src/workerd/io/worker-entrypoint.c++	95.45%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6450      +/-   ##
==========================================
- Coverage   70.79%   70.77%   -0.03%     
==========================================
  Files         427      427              
  Lines      117869   117690     -179     
  Branches    18935    18905      -30     
==========================================
- Hits        83447    83295     -152     
+ Misses      23154    23135      -19     
+ Partials    11268    11260       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.