Skip to content

containers: Add a way to intercept TCP connections from containers#6480

Merged
gabivlj merged 1 commit intomainfrom
gv/tcp-2
Apr 2, 2026
Merged

containers: Add a way to intercept TCP connections from containers#6480
gabivlj merged 1 commit intomainfrom
gv/tcp-2

Conversation

@gabivlj
Copy link
Copy Markdown
Contributor

@gabivlj gabivlj commented Apr 1, 2026

No description provided.

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 1, 2026

I loaded six review skills (kj-style, workerd-safety-review, workerd-api-review, ts-style, pr-review-guide, and identify-reviewer) to prepare for the code review, identified myself as the ask-bonk[bot] reviewer via gh auth status and git config, and fetched the full PR #6480 diff to analyze the changes for adding TCP connection interception to containers.

github run

@gabivlj gabivlj marked this pull request as ready for review April 1, 2026 20:23
@gabivlj gabivlj requested review from a team as code owners April 1, 2026 20:23
@gabivlj gabivlj force-pushed the gv/tcp-2 branch 2 times, most recently from db3bdaa to 92550b3 Compare April 1, 2026 20:30
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.84%. Comparing base (4471142) to head (f329fb8).

Files with missing lines Patch % Lines
src/workerd/server/container-client.c++ 0.00% 64 Missing ⚠️
src/workerd/api/container.c++ 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6480      +/-   ##
==========================================
- Coverage   70.87%   70.84%   -0.04%     
==========================================
  Files         434      434              
  Lines      122003   122063      +60     
  Branches    19104    19109       +5     
==========================================
- Hits        86474    86472       -2     
- Misses      24235    24295      +60     
- Partials    11294    11296       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabivlj gabivlj merged commit 370e96b into main Apr 2, 2026
24 checks passed
@gabivlj gabivlj deleted the gv/tcp-2 branch April 2, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants