You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's no dedicated compat flag for facets. The feature was gated purely behind workerdExperimental. Now let me think through this change:
actor-state.h: Removes the workerdExperimental guard around facets property on DurableObjectState. Now unconditionally exposed.
worker-loader.h: Removes the workerdExperimental guard around getDurableObjectClass method on WorkerStub. Now unconditionally exposed, along with its TS override.
worker-loader-test.js: Removes allowExperimental: true and compatibilityFlags: ['experimental'] from dynamically loaded workers in tests.
worker-loader-test.wd-test: Changes "experimental" to "rpc" (which is actually needed for the RPC features the test uses).
server-test.c++: Bumps compat date to "2026-04-01" and removes "experimental" and "enable_ctx_exports" flags (the new compat date auto-enables enable_ctx_exports).
This is a straightforward change that makes the DO facets API available to all users rather than only to those who opt into experimental. The key question is: should this be gated behind a compatibility flag?
Since this is adding a new property (facets) to DurableObjectState and a new method (getDurableObjectClass) to WorkerStub that weren't previously accessible without experimental, this is additive. It doesn't change existing behavior -- it just makes new APIs available. Generally, new API additions don't need compat flags (those are for behavior changes). This looks safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.