Skip to content

Make SqlStorage::isAllowedName case-insensitive and enforce it on virtual tables (FTS5)#6512

Merged
maxmcd merged 1 commit intomainfrom
mmcdonnell/restrict-reserved-names
Apr 8, 2026
Merged

Make SqlStorage::isAllowedName case-insensitive and enforce it on virtual tables (FTS5)#6512
maxmcd merged 1 commit intomainfrom
mmcdonnell/restrict-reserved-names

Conversation

@maxmcd
Copy link
Copy Markdown
Contributor

@maxmcd maxmcd commented Apr 7, 2026

  • Ensure tables cannot be created with a cf prefix by making the check case-insensitive.
  • Enforce isAllowedName on FTS5 virtual table creation/deletion, which previously bypassed the check
  • Both changes gated behind SQL_RESTRICT_RESERVED_NAMES

@maxmcd maxmcd requested review from a team as code owners April 7, 2026 16:40
@maxmcd maxmcd force-pushed the mmcdonnell/restrict-reserved-names branch from 19c3366 to 5a89f53 Compare April 7, 2026 16:47
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@maxmcd maxmcd force-pushed the mmcdonnell/restrict-reserved-names branch from 5a89f53 to 8ad906d Compare April 7, 2026 16:51
@jasnell
Copy link
Copy Markdown
Collaborator

jasnell commented Apr 7, 2026

PR will need to be rebased on main for CI to run successfully.

@maxmcd maxmcd force-pushed the mmcdonnell/restrict-reserved-names branch 2 times, most recently from 0f02386 to 135a32e Compare April 8, 2026 14:48
and enforce it on virtual tables (FTS5)
@maxmcd maxmcd force-pushed the mmcdonnell/restrict-reserved-names branch from 135a32e to 7c4b038 Compare April 8, 2026 15:40
@maxmcd maxmcd merged commit e10288c into main Apr 8, 2026
22 checks passed
@maxmcd maxmcd deleted the mmcdonnell/restrict-reserved-names branch April 8, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants