Skip to content

Fix experimental queue metrics hanging with missing body size #6521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tewaro merged 1 commit into from
Apr 8, 2026
+6 −1
Merged

Fix experimental queue metrics hanging with missing body size #6521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/workerd/api/queue.c++
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,8 @@ jsg::Promise<WorkerQueue::Metrics> WorkerQueue::metrics(
auto headers = kj::HttpHeaders(context.getHeaderTable());

auto client = context.getHttpClient(subrequestChannel, true, kj::none, "queue_metrics"_kjc);
auto req = client->request(kj::HttpMethod::GET, "https://fake-host/metrics"_kjc, headers);
auto req = client->request(
kj::HttpMethod::GET, "https://fake-host/metrics"_kjc, headers, static_cast<uint64_t>(0));
const auto& headerIds = context.getHeaderIds();

static constexpr auto handleMetrics = [](auto req, auto client,
Expand Down
4 changes: 4 additions & 0 deletions src/workerd/api/tests/queue-metrics-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ export default {
const { pathname } = new URL(request.url);
if (pathname === '/metrics') {
assert.strictEqual(request.method, 'GET');
// Regression test: read the request body before responding, matching
// production behavior. If we omit expectedBodySize on the GET request,
// the body pipe is never closed and this arrayBuffer() call deadlocks
await request.arrayBuffer();
return Response.json({
backlogCount: 100,
backlogBytes: 2048,
Expand Down
Loading