Conversation
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This PR adds step (name + count) and config fields to WorkflowStepContext.
- [MEDIUM]
configshould likely be optional. TheWorkflowStep.do()has an overload that takes noconfigargument. If a user calls that overload, willconfigalways be populated in the context (e.g., with defaults), or will it beundefined? If there's any chance it's not always present, the type should be optional to avoid runtime surprises. - [LOW] Generated snapshots need regeneration. The
types/generated-snapshot/files still show the oldWorkflowStepContextshape (onlyattempt). CI will likely fail on the snapshot diff check. Runjust generate-types(or equivalent) and include the updated snapshots.
This review was written by an AI assistant and may contain inaccuracies.
|
Review posted on PR #6523. Two findings:
|
|
The generated output of |
fcfb215 to
5c864df
Compare
5c864df to
3746353
Compare
No description provided.