Dead code removal: remove no longer used implementations of send and sendBatch#6590
Merged
npaun merged 1 commit intocloudflare:mainfrom Apr 23, 2026
Merged
Conversation
|
Looks good to me! |
npaun
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dead code removal! In
queue.h, there is no longer any reference tosendandsendBatch, both methods were replaced with alternative versions (sendWithResponseandsendBatchWithResponse) that return responses from the upstream Queues codebase rather thanvoid.Note: The new functions are now renamed to
sendandsendBatchafter the dead code implementations were removed.Testing
bazel test //src/workerd/api/tests:queue-test@ //src/workerd/api/tests:queue-metrics-test@ //src/workerd/api/tests:queue-metadata-test@ //src/workerd/api/tests:queue-metrics-sentinel-test@ //src/workerd/api/tests:queue-producer-metadata-test@bazel test //src/workerd/api/tests:queue-test@all-compat-flags //src/workerd/api/tests:queue-metrics-test@all-compat-flags //src/workerd/api/tests:queue-metadata-test@all-compat-flags //src/workerd/api/tests:queue-metrics-sentinel-test@all-compat-flags //src/workerd/api/tests:queue-producer-metadata-test@all-compat-flags