Skip to content

Dead code removal: remove no longer used implementations of send and sendBatch#6590

Merged
npaun merged 1 commit intocloudflare:mainfrom
KennethRuan:kruan/remove-queues-send-dead-code
Apr 23, 2026
Merged

Dead code removal: remove no longer used implementations of send and sendBatch#6590
npaun merged 1 commit intocloudflare:mainfrom
KennethRuan:kruan/remove-queues-send-dead-code

Conversation

@KennethRuan
Copy link
Copy Markdown
Member

@KennethRuan KennethRuan commented Apr 16, 2026

Summary

Dead code removal! In queue.h, there is no longer any reference to send and sendBatch, both methods were replaced with alternative versions (sendWithResponse and sendBatchWithResponse) that return responses from the upstream Queues codebase rather than void.

Note: The new functions are now renamed to send and sendBatch after the dead code implementations were removed.

Testing

  • bazel test //src/workerd/api/tests:queue-test@ //src/workerd/api/tests:queue-metrics-test@ //src/workerd/api/tests:queue-metadata-test@ //src/workerd/api/tests:queue-metrics-sentinel-test@ //src/workerd/api/tests:queue-producer-metadata-test@
  • bazel test //src/workerd/api/tests:queue-test@all-compat-flags //src/workerd/api/tests:queue-metrics-test@all-compat-flags //src/workerd/api/tests:queue-metadata-test@all-compat-flags //src/workerd/api/tests:queue-metrics-sentinel-test@all-compat-flags //src/workerd/api/tests:queue-producer-metadata-test@all-compat-flags

@sdnts
Copy link
Copy Markdown

sdnts commented Apr 16, 2026

Looks good to me!

@KennethRuan KennethRuan marked this pull request as ready for review April 17, 2026 20:02
@KennethRuan KennethRuan requested review from a team as code owners April 17, 2026 20:02
@npaun npaun merged commit 73c75fa into cloudflare:main Apr 23, 2026
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants