Skip to content

[o11y] Introduce distinct event type for STW events#6594

Merged
fhanau merged 1 commit intomainfrom
felix/041626-stw-event-type
Apr 21, 2026
Merged

[o11y] Introduce distinct event type for STW events#6594
fhanau merged 1 commit intomainfrom
felix/041626-stw-event-type

Conversation

@fhanau
Copy link
Copy Markdown
Contributor

@fhanau fhanau commented Apr 16, 2026

This will make it easier to distinguish between STW and BTW invocations internally, each event type should have a distinct type. The authoritative internal definition has already been updated for this.

Also see the internal PR, especially to verify that the right event type is being used.

@fhanau fhanau requested a review from mar-cf April 16, 2026 15:52
@fhanau fhanau requested review from a team as code owners April 16, 2026 15:52
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 16, 2026

UnknownError: ProviderInitError

github run

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 16, 2026

@fhanau Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 16, 2026

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 129 skipped benchmarks1


Comparing felix/041626-stw-event-type (19a302d) with main (45c1208)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@fhanau fhanau force-pushed the felix/041626-stw-event-type branch from cf8dd3d to 718fd87 Compare April 19, 2026 23:36
@jasnell
Copy link
Copy Markdown
Collaborator

jasnell commented Apr 21, 2026

Looks like there are legitmate (non-flaky) CI failures with this change in the internal project.

@fhanau
Copy link
Copy Markdown
Contributor Author

fhanau commented Apr 21, 2026

Looks like there are legitmate (non-flaky) CI failures with this change in the internal project.

Yup, that's because I opened the workerd PR before the internal PR – the internal PR makes some test changes, CI is passing there

This will make it easier to distinguish between STW and BTW invocations
internally, each event type should have a distinct type. The authoritative
internal definition has already been updated for this.
@fhanau fhanau force-pushed the felix/041626-stw-event-type branch from 718fd87 to 19a302d Compare April 21, 2026 17:51
@fhanau fhanau merged commit 432350d into main Apr 21, 2026
22 of 23 checks passed
@fhanau fhanau deleted the felix/041626-stw-event-type branch April 21, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants