Skip to content

compat date for nonretryable release#6627

Merged
tewaro merged 1 commit intomainfrom
vaish/nonretryable-compat-date
Apr 21, 2026
Merged

compat date for nonretryable release#6627
tewaro merged 1 commit intomainfrom
vaish/nonretryable-compat-date

Conversation

@tewaro
Copy link
Copy Markdown
Contributor

@tewaro tewaro commented Apr 21, 2026

Includes a disable flag

Supersedes #6592

Includes a disable flag
@tewaro tewaro requested review from a team as code owners April 21, 2026 07:39
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 21, 2026

UnknownError: ProviderInitError

github run

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 21, 2026

@tewaro Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@vaishnav-mk
Copy link
Copy Markdown
Contributor

lgtm,
cc: @deloreyj

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 21, 2026

The change looks correct:

  1. Ordinal (@170) is unchanged -- this is just modifying annotations on an existing field, not adding a new one.
  2. Enable flag (workflows_preserve_non_retryable_error_message) was already present and is unchanged.
  3. Disable flag (workflows_replace_non_retryable_error_message) is added -- naming follows convention (describes the old behavior).
  4. Enable date (2026-05-14) is ~3 weeks in the future from today (2026-04-21), which is reasonable.
  5. The $experimental annotation is correctly removed since this is being promoted to a standard flag.
  6. The field comment adequately describes the behavior.
  7. No wire-compatibility concerns -- only annotations changed, no field reordering/renaming/removal.

There are no logic bugs, security issues, backward compat violations, or missing compat flags. The disable flag is included. The naming is consistent. The enable date is in the future.

LGTM

github run

@tewaro tewaro enabled auto-merge April 21, 2026 07:45
@tewaro tewaro merged commit e4c3d8b into main Apr 21, 2026
25 of 26 checks passed
@tewaro tewaro deleted the vaish/nonretryable-compat-date branch April 21, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants