Skip to content

Revert "CACHE-13504: remove gate from request cf"#6642

Merged
danlapid merged 1 commit intomainfrom
revert-6630-yawar/rm-exp-gate
Apr 22, 2026
Merged

Revert "CACHE-13504: remove gate from request cf"#6642
danlapid merged 1 commit intomainfrom
revert-6630-yawar/rm-exp-gate

Conversation

@danlapid
Copy link
Copy Markdown
Collaborator

Reverts #6630

@danlapid danlapid requested review from a team as code owners April 22, 2026 22:45
@danlapid danlapid enabled auto-merge (rebase) April 22, 2026 22:46
@danlapid danlapid disabled auto-merge April 22, 2026 22:46
@danlapid danlapid enabled auto-merge April 22, 2026 22:46
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 22, 2026

This is a clean, exact revert of PR #6630. The diff in this PR (#6642) is the exact inverse of #6630's diff. The changes are:

  1. Re-adding the workerdExperimental gate around the cacheControl synthesis and validation logic in http.c++
  2. Re-adding --experimental flag to the test BUILD rule
  3. Re-adding "experimental" compat flag to the .wd-test config
  4. Re-adding the comment about requiring workerd_experimental in the test JS file

This is a straightforward, mechanically-generated revert. The code being restored was previously reviewed and merged. The revert itself is correct — every line matches the inverse of #6630. The PR has already been approved by two reviewers (mar-cf and jasnell).

LGTM

github run

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.49%. Comparing base (4495fba) to head (d973832).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/workerd/api/http.c++ 90.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6642      +/-   ##
==========================================
- Coverage   66.50%   66.49%   -0.02%     
==========================================
  Files         405      405              
  Lines      117811   117814       +3     
  Branches    19428    19429       +1     
==========================================
- Hits        78348    78337      -11     
- Misses      27882    27898      +16     
+ Partials    11581    11579       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 22, 2026

Merging this PR will degrade performance by 12.76%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 71 untouched benchmarks
⏩ 129 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
Encode_ASCII_32[TextEncoder][0/0/32] 2.7 ms 3.1 ms -12.76%

Comparing revert-6630-yawar/rm-exp-gate (d973832) with main (4495fba)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@danlapid danlapid merged commit f936a1d into main Apr 22, 2026
27 of 28 checks passed
@danlapid danlapid deleted the revert-6630-yawar/rm-exp-gate branch April 22, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants