[build] Adopt build without vendored Rust files#6643
Conversation
There was a problem hiding this comment.
Build migration review: switching from vendored crate BUILD files to crate.from_cargo. The bulk of the PR is deletion of generated files, which is great. A few items to address.
Critical: Missing derive feature for clap will break gen-compile-cache.
Minor: Dead code and stale comments from the migration.
|
I'm Bonk, and I've done a quick review of your PR. This PR migrates Rust dependency management from vendored crate BUILD files ( Issues found (ranked by severity):
All issues posted as inline review comments with suggestions where applicable. |
|
The generated output of |
d8e8dc4 to
39f5b4f
Compare
39f5b4f to
3bf1c00
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6643 +/- ##
==========================================
- Coverage 66.49% 66.44% -0.06%
==========================================
Files 405 405
Lines 117814 116097 -1717
Branches 19429 19429
==========================================
- Hits 78342 77142 -1200
+ Misses 27896 27374 -522
- Partials 11576 11581 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance
Comparing Footnotes
|
Derived from #6125, but using plain rules_rust. Note that this can safely be merged by itself without needing a change to the internal rust configuration (as CI will show).