Allow wd_rust_crate to override test size; bump jsg-test to large#6674
Merged
harrishancock merged 1 commit intomainfrom Apr 27, 2026
Merged
Allow wd_rust_crate to override test size; bump jsg-test to large#6674harrishancock merged 1 commit intomainfrom
harrishancock merged 1 commit intomainfrom
Conversation
The default Bazel test size (medium) gives a 15s timeout under our .bazelrc test_timeout settings, which is too tight for jsg-test_test: it has 280+ subtests and is forced to run serially via RUST_TEST_THREADS=1. The test has been observed to hit the 15s wall on three retries in a row in CI. Add a test_size parameter to wd_rust_crate (mirroring the existing parameter on wd_rust_binary) and set test_size = "large" on jsg-test, giving it the 60s timeout it needs. Assisted-by: OpenCode:claude-opus-4.7
Contributor
|
The PR is consistent with the existing LGTM |
npaun
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default Bazel test size (medium) gives a 15s timeout under our .bazelrc test_timeout settings, which is too tight for jsg-test_test: it has 280+ subtests and is forced to run serially via RUST_TEST_THREADS=1. The test has been observed to hit the 15s wall on three retries in a row in CI.
Add a test_size parameter to wd_rust_crate (mirroring the existing parameter on wd_rust_binary) and set test_size = "large" on jsg-test, giving it the 60s timeout it needs.
Assisted-by: OpenCode:claude-opus-4.7