Skip to content

chore: avoid skipping daily release after DevProd dependency updates#6684

Merged
edmundhung merged 1 commit intomainfrom
edmundhung/fix-daily-release-skip
Apr 28, 2026
Merged

chore: avoid skipping daily release after DevProd dependency updates#6684
edmundhung merged 1 commit intomainfrom
edmundhung/fix-daily-release-skip

Conversation

@edmundhung
Copy link
Copy Markdown
Member

Just notice the daily release is skipped yesterday because the last commit comes from the devprod account: d39911c

This make sure it's skipped only if the last commit comes from DevProd and it updated the release-version.txt.

@edmundhung edmundhung requested review from a team as code owners April 28, 2026 13:20
@edmundhung edmundhung requested a review from emily-shen April 28, 2026 13:20
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 28, 2026

Let me think through this carefully.

The change: Previously, the daily release was skipped whenever the last commit's author email was workers-devprod@cloudflare.com. The PR narrows this check so that it only skips when the last commit is from DevProd AND that commit touched release-version.txt — i.e., it was specifically a daily release commit, not some other DevProd dependency update.

Analysis:

  1. The logic is sound. The git diff-tree command checks whether HEAD touched release-version.txt, which correctly distinguishes daily release commits from other DevProd commits.

  2. git diff-tree --no-commit-id --name-only -r HEAD -- src/workerd/io/release-version.txt — this outputs the file path if it was changed in HEAD, or produces no output if not. The [[ ... ]] test evaluates true on non-empty output. This is correct.

  3. The git show --format="%ae" -s retrieves the author email of HEAD. Combined with the diff-tree check, this properly identifies "the last commit was a daily release by DevProd."

  4. The condition at line 52 is correct: proceed unless the last commit is already a daily release.

  5. One subtle thing: git diff-tree with -r HEAD compares HEAD against its parent. For merge commits, this might behave differently (it would show the combined diff). But in this workflow context, daily release commits are simple single-parent commits pushed directly to main, so this is fine.

This is a clean, well-scoped fix. No logic bugs, no security issues, no backward compat concerns.

LGTM

github run

@edmundhung edmundhung merged commit 768f7d8 into main Apr 28, 2026
25 checks passed
@edmundhung edmundhung deleted the edmundhung/fix-daily-release-skip branch April 28, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants