Move package entropy import patches to their own separate file#6696
Move package entropy import patches to their own separate file#6696
Conversation
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This PR moves package-specific entropy import patches out of entropy_import_context.py into a new entropy_import_context_packages.py file, in preparation for disabling them later.
Issues
-
Syntax error (high):
import .entropy_import_context_packageson line 32 ofentropy_import_context.pyis invalid Python syntax. A bareimportstatement does not support relative imports; onlyfrom ... import ...does. This will cause aSyntaxErrorat runtime. -
Unused imports (low): The new
entropy_import_context_packages.pyimportswraps,get_bad_entropy_flag, andraise_unless_entropy_allowedbut none of them are used in the file. These were carried over from the original file's import block.
|
Review posted on PR #6696. Here's a summary of the findings:
All three issues have concrete suggestion comments on the PR. |
1ce6dbd to
1c68851
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6696 +/- ##
=======================================
Coverage 66.55% 66.55%
=======================================
Files 402 402
Lines 115890 115890
Branches 19405 19405
=======================================
Hits 77131 77131
Misses 27188 27188
Partials 11571 11571 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
In preparation to disable them in the future.
1c68851 to
19eec75
Compare
ryanking13
left a comment
There was a problem hiding this comment.
These entropy patches are quite scary, but yeah, moving these to workers-py should give us more control over them.
In preparation to disable them in the future.