Conversation
|
Now I have a clear picture. Let me analyze the key issue: In import { default as entropyImportContextPackages } from 'pyodide-internal:topLevelEntropy/entropy_import_context_packages.py';But it's only used conditionally at line 100-104 (when The Python side handles this by wrapping the import in a However, this is a builtin module import ( Let me verify there are no other issues:
The only potential issue is the unconditional import on line 15 of Actually, let me reconsider — if the flag is on, will this builtin module still be available? These are embedded at build time, so yes. This is a minor inefficiency, not a bug. This is a clean, small PR. The logic is correct. The only observation is the unconditional import at line 15 being a minor waste when the flag is enabled, but that's not actionable in the module system being used here (ES module imports are static and can't be conditional). LGTM |
88121ad to
fc368a8
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
Instead we'll get them from workers-runtime-sdk
fc368a8 to
26ab238
Compare
Instead we'll get them from workers-runtime-sdk