Tweak jsRpcSession() to avoid need for ServerTopLevelMembrane.#6717
Merged
Tweak jsRpcSession() to avoid need for ServerTopLevelMembrane.#6717
jsRpcSession() to avoid need for ServerTopLevelMembrane.#6717Conversation
harrishancock
approved these changes
May 4, 2026
Instead of having the `jsRpcSession()` "hang" until the session is done, we return a capability representing the session which can be dropped to effect cancellation. This avoids the need for the rather-awkward `ServerTopLevelMembrane` on the receiving side. Eliminating this membrane not just reduces complexity, but also fixes a problem where `ExternalPusher` methods had to be invoked strictly in advance of `call()`. I have features planned that will need to be able to call these methods later. Unfortunately this will require a multi-step dance -- clients need to be updated first, then an autogate can update the server, then we can delete old code.
kentonv
force-pushed
the
kenton/jsrpc-membrane-cleanup
branch
from
9c53fcb to
9793e96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having the
jsRpcSession()"hang" until the session is done, we return a capability representing the session which can be dropped to effect cancellation.This avoids the need for the rather-awkward
ServerTopLevelMembraneon the receiving side.Eliminating this membrane not just reduces complexity, but also fixes a problem where
ExternalPushermethods had to be invoked strictly in advance ofcall(). I have features planned that will need to be able to call these methods later.Unfortunately this will require a multi-step dance -- clients need to be updated first, then an autogate can update the server, then we can delete old code.