Skip to content

Add compat-enable-date for process-pth-files#6727

Merged
hoodmane merged 1 commit intomainfrom
hoodmane/pth-enable-date
May 5, 2026
Merged

Add compat-enable-date for process-pth-files#6727
hoodmane merged 1 commit intomainfrom
hoodmane/pth-enable-date

Conversation

@hoodmane
Copy link
Copy Markdown
Contributor

@hoodmane hoodmane commented May 5, 2026

No description provided.

@hoodmane hoodmane requested review from a team as code owners May 5, 2026 20:18
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 5, 2026

The date 2026-05-26 is about 3 weeks in the future from today (May 5, 2026), which is consistent with the pattern of other recent enable dates. The change is minimal and correct:

  1. The flag already had $compatEnableFlag and $compatDisableFlag annotations.
  2. The only change is adding a $compatEnableDate("2026-05-26") to make the flag default-on for workers with compat date >= 2026-05-26.
  3. The semicolon was correctly moved from the $compatDisableFlag line to the new $compatEnableDate line.
  4. The ordinal @176 and field name are unchanged.
  5. The comment block explaining the flag behavior is already present.

This is a clean, one-line-addition change that follows the established patterns in the file. No logic bugs, no backward compatibility issues (the disable flag already exists for opt-out), no security concerns.

LGTM

github run

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 5, 2026

Merging this PR will improve performance by 14.3%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 71 untouched benchmarks
⏩ 129 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
Encode_ASCII_32[TextEncoder][0/0/32] 3.1 ms 2.7 ms +14.3%

Comparing hoodmane/pth-enable-date (88234c0) with main (d3ed2b2)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@hoodmane hoodmane merged commit a79a3b7 into main May 5, 2026
39 of 40 checks passed
@hoodmane hoodmane deleted the hoodmane/pth-enable-date branch May 5, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants