wrangler: reject cross-drive module paths#11888
Merged
petebacondarwin merged 1 commit intocloudflare:mainfrom Mar 16, 2026
Merged
wrangler: reject cross-drive module paths#11888petebacondarwin merged 1 commit intocloudflare:mainfrom
petebacondarwin merged 1 commit intocloudflare:mainfrom
Conversation
🦋 Changeset detectedLatest commit: b4e5830 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
c0d338f to
7a58735
Compare
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
7a58735 to
b12a22e
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
edba71e to
b4e5830
Compare
petebacondarwin
approved these changes
Mar 16, 2026
Contributor
petebacondarwin
left a comment
There was a problem hiding this comment.
Thanks @staticpayload for creating this PR.
I have made a number of fixups and I think it is now in a good place to land.
The main changes were to avoid hard coded regex for drive handling, and more comprehensive checking of the corner cases.
NuroDev
approved these changes
Mar 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing