Skip to content

Conversation

@jkoe-cf
Copy link
Contributor

@jkoe-cf jkoe-cf commented Feb 6, 2026

Fixes #12438
Fixes #12442
Fixes #12460
Fixes MQ-1094

Removing the wrangler default for queues message retention because it is already set to the default value if no value is passed into the API call. Also updating copy around free tier users having a different max retention setting value than paid (message retention must be between 60 and 86400 seconds if on free tier, otherwise must be between 60 and 1209600 seconds).

Otherwise, current workaround is to pass in an explicit message-retention-period-secs value like:

wrangle queues create <queue name> --message-retention-period-secs=100

Also removing the wrangler default for delivery delay because it is also already set to the default value if no value is passed into the API call.

Internal discussion


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: tests should pass again after this change
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Tracked in MQ-1090

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@jkoe-cf jkoe-cf requested a review from a team as a code owner February 6, 2026 23:20
@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2026

🦋 Changeset detected

Latest commit: 5c52f4a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 3 additional findings in Devin Review.

Open in Devin Review

@jkoe-cf jkoe-cf force-pushed the jkoe/update-queues-default-message-retention-value branch from 4039b7e to 6cb017d Compare February 6, 2026 23:24
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 5 additional findings in Devin Review.

Open in Devin Review

@jkoe-cf jkoe-cf force-pushed the jkoe/update-queues-default-message-retention-value branch from 6cb017d to 38c5276 Compare February 6, 2026 23:29
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 6, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12458

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12458

miniflare

npm i https://pkg.pr.new/miniflare@12458

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12458

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12458

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12458

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12458

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12458

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12458

wrangler

npm i https://pkg.pr.new/wrangler@12458

commit: 8364b1e

@jkoe-cf jkoe-cf force-pushed the jkoe/update-queues-default-message-retention-value branch from 38c5276 to 7cc6994 Compare February 6, 2026 23:43
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 4 additional findings in Devin Review.

Open in Devin Review

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Feb 7, 2026
@petebacondarwin
Copy link
Contributor

We need a changeset for this fix. Adding one for you.

@jkoe-cf jkoe-cf force-pushed the jkoe/update-queues-default-message-retention-value branch from f8ff03d to 6bd1a5e Compare February 8, 2026 18:20
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great change to the PR. I assume that there are two defaults internally?
I was worried that it would be a breaking change to change the default.
(We should probably change the PR title, etc).

@jkoe-cf
Copy link
Contributor Author

jkoe-cf commented Feb 8, 2026

This is a great change to the PR. I assume that there are two defaults internally? I was worried that it would be a breaking change to change the default. (We should probably change the PR title, etc).

Yep, free tier and paid users have a different max retention setting value which is handled internally (the default is the same internally as in wrangler, so wrangler doesn't need to send the default).

"wrangler": minor
---

removing default values for message retention to reflect different limits for free tier queues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please maybe add the free and paid limits to the changeset as a reminder?

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit for the changeset.

Thanks!

@@ -196,9 +196,6 @@ describe("wrangler", () => {
if (queueSettings?.delivery_delay === undefined) {
queueSettings.delivery_delay = 0;
}
Copy link
Contributor

@sdnts sdnts Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the same change for the delivery delay as well? (Maybe in a separate PR though)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe #12279 is related to that?
@penalosa ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the PR, description, and changeset to take out the delivery default as well

Co-authored-by: Victor Berchet <victor@suumit.com>
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a bunch of suggestions to how we can lay out the changeset a bit differently. But otherwise LGTM.

jkoe-cf and others added 4 commits February 10, 2026 09:16
Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
@petebacondarwin petebacondarwin merged commit 122791d into cloudflare:main Feb 10, 2026
37 of 38 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

4 participants