Skip to content

Add dev support for experimental secrets property#12701

Merged
jamesopstad merged 6 commits intomainfrom
james/secrets-property-dev
Mar 3, 2026
Merged

Add dev support for experimental secrets property#12701
jamesopstad merged 6 commits intomainfrom
james/secrets-property-dev

Conversation

@jamesopstad
Copy link
Contributor

@jamesopstad jamesopstad commented Feb 27, 2026 •
edited by devin-ai-integration bot
Loading

Add dev support for experimental secrets property.

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: experimental feature

A picture of a cute animal (not mandatory, but encouraged)

Open with Devin

@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 1a754a4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link
Contributor

claude bot commented Feb 27, 2026 •
edited
Loading

Claude encountered an error —— View job

Changeset Review

  • Read changeset guidelines
  • Read changeset file
  • Validate changeset
  • Check for cute animals

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Feb 27, 2026
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 27, 2026 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12701

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12701

miniflare

npm i https://pkg.pr.new/miniflare@12701

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12701

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12701

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12701

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12701

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12701

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12701

wrangler

npm i https://pkg.pr.new/wrangler@12701

commit: ec809c3

@jamesopstad jamesopstad force-pushed the james/secrets-property-dev branch from 64bf5e4 to 5496f65 Compare February 27, 2026 17:01
@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2026 •
edited
Loading

⚠️ Issues found

File: .changeset/quiet-queens-build.md

  1. Missing experimental feature callout: The changeset adds dev support for the experimental secrets property but does not call out that it is experimental or explain how users can opt in. Per the guidelines: "When adding or changing experimental features, call this out explicitly in the changeset description."

  2. Missing body: The changeset has only a title and no body paragraph. The README format requires a <BODY> section explaining the reason for the change and anything notable. For an experimental feature, this body should at minimum explain what the feature does and how to enable/use it.

Suggested fix:

---
"wrangler": minor
---

Add dev support for experimental `secrets` property

This adds local development support for the experimental `secrets` configuration property. This feature is experimental and subject to change.

To opt in, set the `secrets` property in your `wrangler.json`:

```json
{
  "secrets": ["MY_SECRET"]
}

<!-- Sticky Pull Request Commentchangeset-review -->

@jamesopstad jamesopstad force-pushed the james/secrets-property-dev branch 3 times, most recently from 8dba485 to a951fe7 Compare February 27, 2026 17:47
@jamesopstad jamesopstad marked this pull request as ready for review February 27, 2026 17:59
@jamesopstad jamesopstad requested a review from a team as a code owner February 27, 2026 17:59
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@jamesopstad jamesopstad force-pushed the james/secrets-property-dev branch from 704e3b9 to b7c829c Compare March 2, 2026 12:53
penalosa
penalosa previously approved these changes Mar 2, 2026
View reviewed changes
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 2, 2026
@jamesopstad jamesopstad force-pushed the james/secrets-property-dev branch from b7c829c to ff22042 Compare March 2, 2026 17:25
@jamesopstad jamesopstad force-pushed the james/secrets-property-dev branch from ff22042 to 07545e1 Compare March 2, 2026 19:05
@workers-devprod workers-devprod dismissed penalosa’s stale review March 2, 2026 19:06

Changes in owned files since last approval

@workers-devprod
Copy link
Contributor

workers-devprod commented Mar 2, 2026 •
edited
Loading

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@jamesopstad jamesopstad merged commit 23a365a into main Mar 3, 2026
44 of 48 checks passed
@jamesopstad jamesopstad deleted the james/secrets-property-dev branch March 3, 2026 08:28
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 3, 2026
@workers-devprod workers-devprod mentioned this pull request Mar 3, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

@penalosa penalosa penalosa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jamesopstad @workers-devprod @penalosa